Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sendstring call in onekey ADC keymap #10031

Merged
merged 1 commit into from
Aug 16, 2020
Merged

Fix sendstring call in onekey ADC keymap #10031

merged 1 commit into from
Aug 16, 2020

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Aug 13, 2020 •
edited
Loading

Description

Just a tiny bugfix. SEND_STRING(str) is shorthand for send_string_P(PSTR(str)) which doesn't make sense for buffer here, as it has to be stored in RAM, not program memory.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team August 13, 2020 22:57
@fauxpark fauxpark merged commit 48bd826 into qmk:master Aug 16, 2020
@fauxpark fauxpark deleted the onekey-adc-sendstring branch August 16, 2020 22:10
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@fauxpark @nicocesar
Fix sendstring call in onekey ADC keymap (qmk#10031)
434e5c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
bug keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @zvecr