Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redox: sync RGB on left and right sides #10022

Merged
merged 1 commit into from
Aug 17, 2020
Merged

redox: sync RGB on left and right sides #10022

merged 1 commit into from
Aug 17, 2020

Conversation

ceocoder
Copy link
Contributor

Description

Enable left right RGB sync with #define RGBLIGHT_SPLIT macro

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ceocoder
Copy link
Contributor Author

cc @mattdibi

zvecr
zvecr requested changes Aug 13, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be implemented alongside the other RGB config

qmk_firmware/keyboards/redox/rev1/config.h

Lines 60 to 63 in 7c7078f

/* ws2812 RGB LED */
#define RGB_DI_PIN D3
#define RGBLED_NUM 14 // Number of LEDs

@zvecr zvecr added the keyboard label Aug 13, 2020
@zvecr zvecr requested a review from a team August 13, 2020 21:52
@ceocoder
Copy link
Contributor Author

Should be implemented alongside the other RGB config

qmk_firmware/keyboards/redox/rev1/config.h

Lines 60 to 63 in 7c7078f

/* ws2812 RGB LED */
#define RGB_DI_PIN D3
#define RGBLED_NUM 14 // Number of LEDs

done

@zvecr zvecr requested a review from a team August 13, 2020 22:21
@noroadsleft noroadsleft merged commit 3942b6f into qmk:master Aug 17, 2020
@noroadsleft
Copy link
Member

Thanks!

nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@ceocoder @nicocesar
Redox: sync RGB on left and right sides (qmk#10022)
ef69b16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ceocoder @noroadsleft @zvecr @dhaivat