-
-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we need to litter the working directories with .hex files? #670
Comments
so |
@jasonm23, @fredizzimo's sentiments are shared by myself and others, and there are other .hex files that would need to be protected from an @fredizzimo I've been debating moving the |
@jasonm23, Is there a reason why you would want to keep them in the same directory as you run make from? If there are then please tell, because finding out was the reason why I opened an issue rather than do the required quick fix and submit a pull request. And by litter, I really mean that
For normal users that just compile single keyboards this is not a problem, but when you have to try out many of them it starts to be a problem. My numbers are inflated though, as I still have the old .build folders left, which are no longer created as explained below. @jackhumbert I think renaming it to build is a good idea. And actually the build folder is no longer created everywhere, Pull request #596 removed that, well actually #595 did, but that was included in #596. The reason for that chance was a technical one, and it had been mentioned in #591 as one of the things to do anyway, so I changed it immediately instead of trying to fix the issue that was caused by having them all around the place. That said, we could still have some kind of output in other directories as well. But then maybe a |
Hi, I figured the use case where there are many .hex files was very rare.
As a more helpful suggestion than `rm *.hex`, I think a `make` target that selectively cleans up .hex files for a named keyboard would be more useful than changing the default behavior, since neophyte users may get lost trying to find a .hex that isn't in the folder.
My feeling is anyone sufficiently experienced to have an issue, (i.e. Making too many .hex files.) is also adequately prepared to clean up too.
Giving this class of use a helper target is what I would do.
|
@fredizzimo ah, right! Yeah, I think outputting the .hex to the keymap folder probably makes the most sense for organisation, especially since the I think it'd be sufficient to just put the .hex files (optionally .bin files, if specified in the Makefile) in the keymap folders, without a |
This was fixed a long time ago. |
* Add keyboard: KMAC Happy & Porting to Vial. * Add Vial support for keyboard: JER J80. * Revert info.json * Revert keymap.c * Revert keymap.c * remove defaults in rules.mk Co-authored-by: Less/Rikki <[email protected]> * add layer count in config.h Co-authored-by: Less/Rikki <[email protected]> * remove QMKBEST codes Co-authored-by: Less/Rikki <[email protected]> * remove hardcode in keymap.c Co-authored-by: Less/Rikki <[email protected]> * remove QMKBEST codes Co-authored-by: Less/Rikki <[email protected]> * remove hardcode in keymap.c Co-authored-by: Less/Rikki <[email protected]> * Revert readme.md * Revert rules.mk * enable MOUSEKEY as defaults --------- Co-authored-by: Less/Rikki <[email protected]>
I'm slightly annoyed by the fact that the build system output .hex files in the same directory as you run the make. It makes it hard to navigate the file system and see the important things.
In addition to that they can already be found in the .build folder, but since that folder is hidden, maybe the should go to something like
/firmware
? I chose the namefirmware
instead of hex, because some keyboards need bin files instead.Also, in most cases the user don't need to care about the files at all, since the make command does everything.
The text was updated successfully, but these errors were encountered: