Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot enable auto-shift and HOLD_ON_OTHER_KEY_PRESS_PER_KEY at the same time #18855

Closed
2 tasks
nicknimchuk opened this issue Oct 26, 2022 · 0 comments
Closed
2 tasks

Comments

@nicknimchuk
Copy link
Contributor

nicknimchuk commented Oct 26, 2022

Describe the Bug

The function prototype for get_hold_on_other_key_press is missing from /quantum/action_tapping.h. This usually doesn't cause a problem, even with HOLD_ON_OTHER_KEY_PRESS_PER_KEY enabled in config.h; however, with auto-shift also enabled, the following error is generated while compiling:

Compiling: quantum/process_keycode/process_auto_shift.c                                            quantum/process_keycode/process_auto_shift.c: In function 'process_auto_shift':
quantum/process_keycode/process_auto_shift.c:406:23: error: implicit declaration of function 'get_hold_on_other_key_press' [-Werror=implicit-function-declaration]
  406 |                     ? get_hold_on_other_key_press(keycode, record)
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1.exe: all warnings being treated as errors

Adding the prototype in action_tapping.h with the other mod-tap prototypes fixes the error.

Keyboard Used

No response

Link to product page (if applicable)

No response

Operating System

No response

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

@nicknimchuk nicknimchuk changed the title [Bug] get_hold_on_other_key_press function prototype missing from action_tapping.h [Bug] Cannot enable auto-shift and HOLD_ON_OTHER_KEY_PRESS_PER_KEY at the same time Oct 26, 2022
@tzarc tzarc closed this as completed in c1ef943 Nov 27, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this issue Nov 28, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this issue Dec 7, 2022
crembz pushed a commit to crembz/qmk_firmware that referenced this issue Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant