You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function prototype for get_hold_on_other_key_press is missing from /quantum/action_tapping.h. This usually doesn't cause a problem, even with HOLD_ON_OTHER_KEY_PRESS_PER_KEY enabled in config.h; however, with auto-shift also enabled, the following error is generated while compiling:
Compiling: quantum/process_keycode/process_auto_shift.c quantum/process_keycode/process_auto_shift.c: In function 'process_auto_shift':
quantum/process_keycode/process_auto_shift.c:406:23: error: implicit declaration of function 'get_hold_on_other_key_press' [-Werror=implicit-function-declaration]
406 | ? get_hold_on_other_key_press(keycode, record)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1.exe: all warnings being treated as errors
Adding the prototype in action_tapping.h with the other mod-tap prototypes fixes the error.
Keyboard Used
No response
Link to product page (if applicable)
No response
Operating System
No response
qmk doctor Output
No response
Is AutoHotKey / Karabiner installed
AutoHotKey (Windows)
Karabiner (macOS)
Other keyboard-related software installed
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered:
nicknimchuk
changed the title
[Bug] get_hold_on_other_key_press function prototype missing from action_tapping.h
[Bug] Cannot enable auto-shift and HOLD_ON_OTHER_KEY_PRESS_PER_KEY at the same time
Oct 26, 2022
Describe the Bug
The function prototype for
get_hold_on_other_key_press
is missing from/quantum/action_tapping.h
. This usually doesn't cause a problem, even withHOLD_ON_OTHER_KEY_PRESS_PER_KEY
enabled inconfig.h
; however, with auto-shift also enabled, the following error is generated while compiling:Adding the prototype in
action_tapping.h
with the other mod-tap prototypes fixes the error.Keyboard Used
No response
Link to product page (if applicable)
No response
Operating System
No response
qmk doctor Output
No response
Is AutoHotKey / Karabiner installed
Other keyboard-related software installed
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: