Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Adafruit BLE UART Friend support #10674

Closed
2 of 4 tasks
kanru opened this issue Oct 17, 2020 · 2 comments
Closed
2 of 4 tasks

[Feature Request] Adafruit BLE UART Friend support #10674

kanru opened this issue Oct 17, 2020 · 2 comments
Labels
enhancement help wanted stale Issues or pull requests that have become inactive without resolution.

Comments

@kanru
Copy link

kanru commented Oct 17, 2020

Feature Request Type

  • Core functionality
  • Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

Hi, I'm working on a qmk fork of the YANG's HHKB BLE mod. The controller uses the MDBT40 module and Adafruit BLE UART Friend's firmware. I have a working version using the UART protocol here: https://github.com/kanru/qmk_firmware/blob/hhkb_yang/tmk_core/protocol/lufa/adafruit_ble_uart.c

The UART version implements all of the interface defined in adafruit_ble.h so I didn't have to change other places to enable send keys or outputselect. As you see most of the AT commands are the same and the sequence is the same, just the transport is different and some additional functionality for battery service.

I would like open a pull request to merge this code but I want to discuss how the project would like to structure the code first. I'm aware there is already a pull request #8982 but I think a simpler approach would be making an abstract interface for the AT command transport layer and implement an adafruit ble driver on top of it. What do you think? Any suggestion about the file path and directory structure?

@stale
Copy link

stale bot commented Jan 15, 2021

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@stale stale bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 15, 2021
@stale
Copy link

stale bot commented Feb 14, 2021

This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

No branches or pull requests

1 participant