You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The UART version implements all of the interface defined in adafruit_ble.h so I didn't have to change other places to enable send keys or outputselect. As you see most of the AT commands are the same and the sequence is the same, just the transport is different and some additional functionality for battery service.
I would like open a pull request to merge this code but I want to discuss how the project would like to structure the code first. I'm aware there is already a pull request #8982 but I think a simpler approach would be making an abstract interface for the AT command transport layer and implement an adafruit ble driver on top of it. What do you think? Any suggestion about the file path and directory structure?
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.
stalebot
added
the
stale
Issues or pull requests that have become inactive without resolution.
label
Jan 15, 2021
This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know.
Feature Request Type
Description
Hi, I'm working on a qmk fork of the YANG's HHKB BLE mod. The controller uses the MDBT40 module and Adafruit BLE UART Friend's firmware. I have a working version using the UART protocol here: https://github.com/kanru/qmk_firmware/blob/hhkb_yang/tmk_core/protocol/lufa/adafruit_ble_uart.c
The UART version implements all of the interface defined in
adafruit_ble.h
so I didn't have to change other places to enable send keys or outputselect. As you see most of the AT commands are the same and the sequence is the same, just the transport is different and some additional functionality for battery service.I would like open a pull request to merge this code but I want to discuss how the project would like to structure the code first. I'm aware there is already a pull request #8982 but I think a simpler approach would be making an abstract interface for the AT command transport layer and implement an adafruit ble driver on top of it. What do you think? Any suggestion about the file path and directory structure?
The text was updated successfully, but these errors were encountered: