Applying core review suggestions

qmk · Nov 24, 2024 · a20661f · a20661f
1 parent a8ca921
commit a20661f
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 15 deletions.
diff --git a/keyboards/marcopad/config.h b/keyboards/marcopad/config.h
diff --git a/keyboards/marcopad/keyboard.json b/keyboards/marcopad/keyboard.json
@@ -6,6 +6,8 @@
 	"diode_direction": "ROW2COL",
 	"features": {
 		"bootmagic": true,
+		"rgblight": true,
+		"combo": true,
 		"command": false,
 		"console": false,
 		"extrakey": false,
@@ -22,7 +24,8 @@
 		"pid": "0x0000",
 		"vid": "0xFEED"
 	},
-	"backlight": {
+	"ws2812": {
+		"driver": "vendor",
 		"pin": "GP28"
 	},
 	"rgblight": {
@@ -42,8 +45,9 @@
 			"twinkle": true
 		}
 	},
+	"community_layouts": ["ortho_3x3"],
 	"layouts": {
-		"LAYOUT": {
+		"LAYOUT_ortho_3x3": {
 			"layout": [
 				{ "matrix": [0, 0], "x": 0, "y": 0 },
 				{ "matrix": [0, 1], "x": 0, "y": 1 },

diff --git a/keyboards/marcopad/keymaps/default/keymap.c b/keyboards/marcopad/keymaps/default/keymap.c
@@ -13,7 +13,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
      * │ 1 │ 2 │ 3 │
      * └───┴───┴───┘
      */
-    [0] = LAYOUT(
+    [0] = LAYOUT_ortho_3x3(
         KC_P7,   KC_P8,   KC_P9,
         KC_P4,   KC_P5,   KC_P6,
         KC_P1,   KC_P2,   KC_P3

diff --git a/keyboards/marcopad/keymaps/default/rules.mk b/keyboards/marcopad/keymaps/default/rules.mk
diff --git a/keyboards/marcopad/readme.md b/keyboards/marcopad/readme.md
@@ -1,12 +1,12 @@
 # Marcopad
 
-![macropad](imgur.com image replace me!)
+![marcopad](https://pelegrini.ca/assets/img/marcopad/hardware/macropad.png)
 
 *A compact 3x3 keys macropad built with RP-2040 Zero*
 
-* Keyboard Maintainer: [Marco Pelegrini](https://pelegrini.ca/marcopad)
-* Hardware Supported: [Macropad PCB](https://pelegrini.ca/marcopad/hardware)
-* Hardware Availability: [Macropad](https://pelegrini.ca/marcopad)
+* Keyboard Maintainer: [pelegrini.ca](https://pelegrini.ca/marcopad)
+* Hardware Supported: [Marcopad](https://pelegrini.ca/marcopad)
+* Hardware Availability: [Marcopad](https://pelegrini.ca/marcopad)
 
 Make example for this keyboard (after setting up your build environment):