Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keymap] Add qmk_configurator keymap chavdai40 #789

Merged
merged 2 commits into from
Aug 13, 2020

Conversation

dvorak55
Copy link
Contributor

@dvorak55 dvorak55 commented Aug 9, 2020

Hi, I want to add keymap/c/chavdai40_default.json.

Firmware of chavdai40 PR is qmk/qmk_firmware#9820(merged)

@dvorak55 dvorak55 changed the title add qmk_configurator keymap chavdai40 [Keymap] Add qmk_configurator keymap chavdai40 Aug 9, 2020
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestions base the keymap on the default keymap, instead of 42keys-qwerty.

public/keymaps/c/chavdai40_default.json Outdated Show resolved Hide resolved
public/keymaps/c/chavdai40_default.json Outdated Show resolved Hide resolved
public/keymaps/c/chavdai40_default.json Outdated Show resolved Hide resolved
@dvorak55
Copy link
Contributor Author

Thanks for noroadsleft!
I just committed suggestions of you.

@noroadsleft noroadsleft merged commit 6f4303b into qmk:master Aug 13, 2020
@noroadsleft
Copy link
Member

Thanks!

@dvorak55 dvorak55 deleted the add_keymap_chavdai40 branch September 1, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants