Add default Wete keymap #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
requested changes
Feb 25, 2020
There was a problem hiding this comment.
These changes will make the keymap more visually polished when rendered. Configurator's UI code currently largely only understands short-form keycodes rather than full-length (e.g. KC_INS instead of KC_INSERT, though both work when compiled).
You also have an extra comma on Line 22.
Change to shortform keycodes, remove extra comma Co-Authored-By: James Young <[email protected]>
noroadsleft
approved these changes
Feb 26, 2020
|
Keymap looks good but it doesn't compile; this is something on our end. 🙁 Lemme chase that down and then I'll merge this. Your part's done. 🙂 |
noroadsleft
added
the
on hold
|
Great. Thanks for all your help here and in the main repo! |
13 tasks
noroadsleft
removed
the
on hold
|
Compile issue was fixed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the default keymap for the configurator following qmk/qmk_firmware#8229.