add tada68 default ANSI layout #143
Conversation
|
The TADA68 is not fully supported on the Configurator. You need a bin file in order to properly flash the TADA68. The configurator currently does not let you do this. All the defaults will also be automatically generated in the near future. @yanfali the .json looks correct, but I don't think it will do anything useful. I suppose people could make the keymap, compile, and download source, and then compile the bin file? |
|
@mechmerlin Yes this is mainly so that people can at least configure their choice of layout with an editor instead of doing it by hand and then either export the json or just download the sources (or the hex for those who have flashed the dfu bootloader). |
|
@shalzz this looks great, but can we fix the compile issues? |
|
@yanfali This is the compile errors I get: Which, as you can imagine, is difficult for me to decipher. I dunno if its because of my system font or the websites. |
|
I'll take a look it's probably because we don't have a way to pass options
to backend from configurator yet.
…On Mon, Jun 11, 2018, 09:42 Shaleen Jain ***@***.***> wrote:
@yanfali <https://github.com/yanfali> This is the compile errors I get:
�
Some git sub-modules are out of date or modified, please consider runnning:�
make git-submodule
You can ignore this warning if you are not compiling any ChibiOS keyboards,
or if you have modified the ChibiOS libraries yourself.
�
avr-gcc (GCC) 4.9.2
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Compiling: keyboards/tada68/tada68.c �
Compiling: keyboards/tada68/keymaps/default1/keymap.c In file included from ��[K:
��[K’ undeclared here (not in a function)
O(_FL), KC_RCTL, KC_LEFT, KC_DOWN, KC_RGHT),
��[K
��[K’
{k40, k41, k42, XXX, XXX, k45, XXX, XXX, XXX, k49, k4a, k4b, k4c, k4d, k4e} \
��[K
��[K’
O(_FL), KC_RCTL, KC_LEFT, KC_DOWN, KC_RGHT),
��[K
�
|
|
|
tmk_core/rules.mk:357: recipe for target '.build/obj_tada68_default1/keyboards/tada68/keymaps/default1/keymap.o' failed
makeap.o] Error 1
Makefile:534: recipe for target 'tada68:default1' failed
make: *** [tada68:default1] Error 1
�ake finished with errors
�
Which, as you can imagine, is difficult for me to decipher. I dunno if its
because of my system font or the websites.
It seems it is an issue with the compile server and not directly with the
json. Maybe perhaps the MOUSEKEY_ENABLE option is not enabled?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#143 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACK5U-VQlChx2AHRIS0GvGhmHWaJ5xCMks5t7p4NgaJpZM4UiU5U>
.
|
|
OK, looks like there's an error in the info.json "Error: tada68: KEYMAP_ISO: Number of elements in info.json does not match! info.json:69 != KEYMAP_ISO:68" I'm not sure what the backend does if only 1 layout is wrong. That may explain the name collision error, which I've never seen before. @skullydazed any feedback? |
|
How exactly is the server setup and is the source available? If it is maybe I could look into it. |
|
@shalzz https://github.com/qmk/qmk_api/blob/master/docs/development_overview.md is a good place to start |
keymaps/tada68_default.json
Outdated
| { | ||
| "keyboard": "tada68", | ||
| "keymap": "default", | ||
| "layout": "KEYMAP_ANSI", |
There was a problem hiding this comment.
Change KEYMAP_ANSI to LAYOUT_ansi here.
The name of the key matrix was changed after you submitted this PR.
keymaps/tada68_default.json
Outdated
| "KC_TAB","KC_Q","KC_W","KC_E","KC_R","KC_T","KC_Y","KC_U","KC_I","KC_O","KC_P","KC_LBRC","KC_RBRC","KC_BSLS","KC_DEL", | ||
| "KC_CAPS","KC_A","KC_S","KC_D","KC_F","KC_G","KC_H","KC_J","KC_K","KC_L","KC_SCLN","KC_QUOT","KC_ENT","KC_PGUP", | ||
| "KC_LSFT","KC_Z","KC_X","KC_C","KC_V","KC_B","KC_N","KC_M","KC_COMM","KC_DOT","KC_SLSH","KC_RSFT","KC_UP","KC_PGDN", | ||
| "KC_LCTL","KC_LGUI","KC_LALT","KC_SPC","KC_RALT","MO(_FL)","KC_RCTL","KC_LEFT","KC_DOWN","KC_RGHT"], |
There was a problem hiding this comment.
@shalzz please change MO(_FL) to MO(1) - we only support integer layer changes at this time. That should fix the compile
|
LGTM. Thank you @shalzz |
|
@noroadsleft @yanfali Thanks for your work and review. I have made the relevant changes and it does compile successfully now. There is still the name collision error because of the already existing "default" keymap in qmk_firmware. Maybe add a prefix like "config-" for all keymap names used with qmk_configurator? |
|
I just renamed it. It turns out you can't have a keymap name that is the
same as an existing one. So I renamed yours to default_ansi and that fixed
it. Thanks again for the contribution. Much appreciated.
…On Mon, Jun 18, 2018 at 10:48 PM Shaleen Jain ***@***.***> wrote:
@noroadsleft <https://github.com/noroadsleft> @yanfali
<https://github.com/yanfali> Thanks for your work and review. I have made
the relevant changes and it does compile successfully now.
There is still the name collision error because of the already existing
"default" keymap in qmk_firmware. Maybe add a prefix like "config-" for all
keymap names used with qmk_configurator?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#143 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACK5U-YXLNKggwKMmP2AF6346x9qoZxsks5t-JCQgaJpZM4UiU5U>
.
|
Default layout same as https://github.com/qmk/qmk_firmware/tree/master/keyboards/tada68/keymaps/default
Though the mouse keycodes do not render properly on the editor.
And I'm getting some compile errors after changing the Keymap name due to "Keymap name collision!"