Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arm Teensys to ARM_PROCESSORS list #61

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Add Arm Teensys to ARM_PROCESSORS list #61

merged 1 commit into from
Mar 5, 2020

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Mar 1, 2020

API error log is listing a handful of these type of messages:

Warning: ergodox_infinity: Unknown MCU: MK20DX256

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from a team March 3, 2020 03:43
@tzarc
Copy link
Member

tzarc commented Mar 3, 2020

Should we look at a longer-term fix using qmk/qmk_firmware#8256 ?

They get transformed during build, based on https://github.com/qmk/qmk_firmware/blob/master/quantum/mcu_selection.mk

@fauxpark
Copy link
Member Author

fauxpark commented Mar 3, 2020

I would like to figure out how to retain the original MCU name here, as cortex-m0 isn't all that descriptive.

@skullydazed
Copy link
Member

Should we look at a longer-term fix using qmk/qmk_firmware#8256 ?

I'm with @fauxpark here, it'd be good to retain the MCU. If we want to extrapolate to generic names we should use a variable other than MCU.

@skullydazed skullydazed merged commit 1336a45 into qmk:master Mar 5, 2020
@fauxpark fauxpark deleted the arm-teensys branch March 5, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants