Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ospfd: zlog_ferr facility #6

Commits on Jun 14, 2018

  1. lib: add error reference system

    * Add zlog_* function to log with a reference code
    * Add ability to track reference cards for errors to ferr.[ch]
    * Assign some reference code ranges
    
    Signed-off-by: Quentin Young <[email protected]>
    qlyoung committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    acf7cd5 View commit details
    Browse the repository at this point in the history
  2. lib: Allow adding arrays of ferr's

    Simplify addition of new messages to the system by allow passage of
    arrays of data, instead of one at a time.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp authored and qlyoung committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    bcbb21c View commit details
    Browse the repository at this point in the history
  3. lib, bgpd: Add code to make lib auto create the ferr infrastructure

    Add code to auto-create the ferr infrastructure as well as add
    some initial error handling for vrf.c
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp authored and qlyoung committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    752d1b9 View commit details
    Browse the repository at this point in the history
  4. lib: Convert to zlog_ferr for zclient.c

    Convert the zclient.c file to use zlog_ferr.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp authored and qlyoung committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    22de4e6 View commit details
    Browse the repository at this point in the history
  5. *: ALLOC calls cannot fail

    There is no need to check for failure of a ALLOC call
    as that any failure to do so will result in a assert
    happening.  So we can safely remove all of this code.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp authored and qlyoung committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    a71dd8d View commit details
    Browse the repository at this point in the history
  6. lib: When logging commands do not use zlog_err

    When we are logging a commands via the `log commands`
    cli, use zlog_notice instead of zlog_err, since that
    this is not an actual error situation.
    
    Signed-off-by: Donald Sharp <[email protected].
    donaldsharp authored and qlyoung committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    b663b3c View commit details
    Browse the repository at this point in the history
  7. lib: Add LIB_ERR_SYSTEM_CALL and convert VRF_SOCKET to SOCKET

    Add a new error code LIB_ERR_SYSTEM_CALL to the ferr subsystem.
    Additionally convert LIB_ERR_VRF_SOCKET to a more generic
    LIB_ERR_SOCKET.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp authored and qlyoung committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    a827b03 View commit details
    Browse the repository at this point in the history
  8. lib: Add LIB_ERR_VTY

    Add a error code for when the vty subsystem detects
    an error.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp authored and qlyoung committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    55c636b View commit details
    Browse the repository at this point in the history
  9. lib: Add LIB_ERR_SNMP

    Add code to indicate a SNMP error of some sort that needs to be
    handled and addressed.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp authored and qlyoung committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    faa0857 View commit details
    Browse the repository at this point in the history
  10. bgpd, lib, zebra: Convert LIB_ERR_PRIVILEGES

    For all the places we zlog_err about raising/lowering privileges, use
    zlog_ferr.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp authored and qlyoung committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    43afe00 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2018

  1. Configuration menu
    Copy the full SHA
    8cc9a11 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2018

  1. lib, zebra: Add LIB_ERR_INTERFACE

    Add a error type that allows us to track bad interface states.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    5c77713 View commit details
    Browse the repository at this point in the history
  2. lib: Add LIB_ERR_NS to error subsystem

    Add additional information about NameSpace errors that
    may happen.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    9d36bf3 View commit details
    Browse the repository at this point in the history
  3. lib: Add LIB_ERR_DEVELOPMENT

    Sometimes a error state is detected when we have added
    new code to FRR, but not updated all the places that
    we should have.  Consider this a developmental escape
    that needs to be fixed.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    d5f2c45 View commit details
    Browse the repository at this point in the history
  4. lib: Remove memory check test

    Found a missed memory check test that can just be removed.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    815d5a4 View commit details
    Browse the repository at this point in the history
  5. lib: Add LIB_ERR_ZMQ

    Add new error event for when we detect an issue within
    the ZMQ subsystem.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    61b59c0 View commit details
    Browse the repository at this point in the history
  6. lib: Cleanup some missed LIB_ERR_SYSTEM_CALL

    libfrr.c had some detection for system call issues.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    e9550d0 View commit details
    Browse the repository at this point in the history
  7. ospf6d: Update OSPFv3 to use new zlog_ferr

    Update OSPFv3 to use the new zlog_ferr messages
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    546f4db View commit details
    Browse the repository at this point in the history
  8. ripd: Convert zlog_err to zlog_ferr for LIB_ERR_XXX

    For those errors that can be traced to LIB_ERR_XXX
    convert to using those in ripd.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    3527a27 View commit details
    Browse the repository at this point in the history
  9. ripngd: Convert over to using LIB_ERR_XXXX for zlog_ferr

    Convert over those zlog_err functions to zlog_ferr that
    are appropriate for the LIB_ERR_XXX.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    8d0f19c View commit details
    Browse the repository at this point in the history
  10. pimd: Convert over to use LIB_ERR_XXX for zlog_err

    Convert, where appropriate, the zlog_err functions to zlog_ferr
    for the LIB_ERR_XXX enums
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    128bbc2 View commit details
    Browse the repository at this point in the history
  11. lib: Update error ranges to include all daemons

    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    1151a3d View commit details
    Browse the repository at this point in the history
  12. eigrpd: Convert to use LIB_ERR_XXX for zlog_err

    Convert, where appropriate, to using LIB_ERR_XXX for zlog_ferr
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    a02ec79 View commit details
    Browse the repository at this point in the history
  13. ldpd: Convert to using LIB_ERR_XXX and zlog_ferr

    convert ldpd over to using zlog_ferr and LIB_ERR_XXX
    where appropriate.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    c3c755b View commit details
    Browse the repository at this point in the history
  14. ospfd: Memory asserts on failure to create no need to check

    Memory Asserts on failure to allocate new memory, no need
    to check for success failure in these cases.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    9014283 View commit details
    Browse the repository at this point in the history
  15. Merge pull request FRRouting#3 from donaldsharp/more_error_stuff

    More error stuff
    qlyoung authored Jun 18, 2018
    Configuration menu
    Copy the full SHA
    e5beeb8 View commit details
    Browse the repository at this point in the history
  16. Merge pull request FRRouting#2 from dslicenc/bgp-error-reference

    bgpd: implement zlog_ferr facility for enhance error messages in bgp
    qlyoung authored Jun 18, 2018
    Configuration menu
    Copy the full SHA
    e00493d View commit details
    Browse the repository at this point in the history
  17. bgpd: Cleanup initialization of bgp_errors.c

    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    607ecb0 View commit details
    Browse the repository at this point in the history
  18. pimd: Add pim_errors and define some pim specific errors

    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    77dae04 View commit details
    Browse the repository at this point in the history
  19. babeld: Add BABEL_ERR_XXX error messages.

    Add some BABEL_ERR_XXX error messages and convert over to using
    zlog_ferr instead of zlog_err.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    0bef3e0 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    d7ef705 View commit details
    Browse the repository at this point in the history
  21. babeld: Convert all zlog_err to zlog_ferr and add appropriate info

    Convert babeld to use zlog_ferr and add appropriate BABEL_ERR_XXX
    information.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    23f3240 View commit details
    Browse the repository at this point in the history
  22. isisd: Convert to use LIB_ERR_XXX

    Where an obvious choice could be made about converting
    to a LIB_ERR_XXX function do so.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    6b29bfa View commit details
    Browse the repository at this point in the history
  23. isisd: Add isis_errors and generate custom Error Codes

    Generate appropriate error codes for ISIS.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    8578990 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2018

  1. Merge pull request FRRouting#4 from donaldsharp/more_error_stuff

    More error stuff
    qlyoung authored Jun 19, 2018
    Configuration menu
    Copy the full SHA
    741faf9 View commit details
    Browse the repository at this point in the history
  2. isisd: Cleanup compile issue

    cleanup compile with missnamed enum usage.
    
    Signed-off-by: Donald Sharp <[email protected]>
    donaldsharp committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    17f5548 View commit details
    Browse the repository at this point in the history
  3. Merge pull request FRRouting#5 from donaldsharp/error-reference-cards

    isisd: Cleanup compile issue
    qlyoung authored Jun 19, 2018
    Configuration menu
    Copy the full SHA
    48157ee View commit details
    Browse the repository at this point in the history
  4. ospfd: zlog_ferr facility

    Ticket:CM-21333
    
    Signed-off-by: Chirag Shah <[email protected]>
    chiragshah6 committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    2dd67ae View commit details
    Browse the repository at this point in the history