Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.0.13 #492

Merged
merged 27 commits into from
Sep 2, 2022
Merged

Release v4.0.13 #492

merged 27 commits into from
Sep 2, 2022

Conversation

devonpis
Copy link
Contributor

@devonpis devonpis commented Sep 1, 2022

sync master with v4.0.13

devonpis and others added 25 commits May 4, 2022 16:32
* Minimize search component

* Minimize search component
* QOL-8843
Improvement: Multi-select (Form.io) component styles

* QOL-8843
Improvement: Multi-select (Form.io) component styles

* updated styles

* updated styles

* QOL-8843
Improvement: Multi-select (Form.io) component styles

* QOL-8843
Improvement: Multi-select (Form.io) component styles

* QOL-8843
Improvement: Multi-select (Form.io) component styles
* alert box spacing

* alert box spacing
* add css helper class

* add and expose global css variables

* add spinner component

* fix typo
* update component stories
* update card style

* fix card style
* update spinner default style
* forms.io styles update

* forms.io styles update

* styles update
@devonpis devonpis requested a review from a team September 1, 2022 22:49
Copy link
Member

@duttonw duttonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have an example with bitdegree . org in the redirect?

@@ -33,7 +33,7 @@ module.exports = function (gulp, plugins, config, destFolder = 'assets', addSrc)
browsers: plugins.supportedBrowser,
cascade: false,
}))
.pipe(sourcemaps.write())
.pipe(sourcemaps.write('.'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write maps file for debugging in the same folder for local development. Earlier it was outputting in the root, so Chrome could not detect it.

<meta http-equiv="refresh" content="2; URL=https://www.bitdegree.org/" />
</head>
<body>
<p>If you are not redirected in 2 seconds, <a href="https://www.bitdegree.org/">click here</a>.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats this? this does not look right

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted the content, some test content got committed. Those are just examples for internal testing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats this? this does not look right

I deleted those examples of specific forms as those might cause some issues if those are not live and in the examples folder if someone finds those.

}
};
</script>
<style>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asifamingov this style tag has been removed in squiz matrix component

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example page copied from Squiz, some particular form. So this is present on some forms.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asifamingov this style tag has been removed in squiz matrix component

I deleted those examples of specific forms as those might cause some issues if those are not live and in the examples folder if someone finds those.

@devonpis devonpis requested a review from duttonw September 2, 2022 01:47
@devonpis devonpis merged commit ff92f61 into master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants