Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http.request.js fails when the response body is empty #98

Closed
s3u opened this issue Nov 23, 2011 · 1 comment
Closed

http.request.js fails when the response body is empty #98

s3u opened this issue Nov 23, 2011 · 1 comment
Assignees
@shimonchayim
Milestone
M5

Comments

@s3u
Copy link
Member

s3u commented Nov 23, 2011

Line 400: respJson = JSON.parse(respData);

This should be skipped for empty bodies.

In one particular case, the server returned 404 with no body, but the client never gets to see the 404 due to JSON.parse failing error.
@ghost ghost assigned prabhakhar Nov 23, 2011
@ghost ghost assigned shimonchayim Dec 1, 2011
@shimonchayim
Copy link
Member

Fixed waiting for pull.

s3u pushed a commit that referenced this issue Dec 6, 2011
Merge pull request #131 from shimonchayim/master
18d8476 
Fix for issue #98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shimonchayim shimonchayim

Labels
None yet
Projects
None yet
Milestone
M5
Development

No branches or pull requests
3 participants
@s3u @shimonchayim @prabhakhar