Add temporary fix for ARM64 Mac _Float16 build failure (HDFGroup#4639)

qkoziol · Jul 15, 2024 · 74fbc1d · 74fbc1d
1 parent 6fa09bd
commit 74fbc1d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/main-cmake.yml b/.github/workflows/main-cmake.yml
@@ -110,7 +110,7 @@ jobs:
           # but that seems unnecessary
           - name: "MacOS Clang"
             os: macos-latest
-            cpp: OFF
+            cpp: ON
             fortran: ON
             java: ON
             docs: ON

diff --git a/src/H5private.h b/src/H5private.h
@@ -586,8 +586,14 @@
  * _Float16 type to avoid issues when compiling the library
  * with the -pedantic flag or similar where we get warnings
  * about _Float16 not being an ISO C type.
+ *
+ * Due to the inclusion of H5private.h from the C++ wrappers,
+ * this typedef creation must be avoided when __cplusplus is
+ * defined to avoid build failures on ARM64 Macs. GCC and
+ * Clang either do not currently provide a _Float16 type for
+ * C++ on ARM64, or may need an additional compile-time flag.
  */
-#ifdef H5_HAVE__FLOAT16
+#if defined(H5_HAVE__FLOAT16) && !defined(__cplusplus)
 #if defined(__GNUC__)
 __extension__ typedef _Float16 H5__Float16;
 #else