-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Add qiskit sphinx theme #72
[DOC] Add qiskit sphinx theme #72
Conversation
@caleb-johnson @garrison @Eric-Arellano ready for review :) I had to up the minimal version of python. The qiskit template need sphinx 6 who had a requirement of python >=3.8 (see sphinx package pypi). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pardon the delay! I was OOO. Thanks!
Co-authored-by: Eric Arellano <[email protected]>
Of course no problem, I also was last week ;) I took your feedbacks and applied them. |
I'll also cover the issue #17 ... working on it 🏗️ |
@garrison @caleb-johnson ready for your review about everything :) |
o-authored-by: Eric Arellano <[email protected]>
Co-authored-by: Eric Arellano <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
Thanks Eric 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @Eric-Arellano and @mickahell !
Summary
Use the new qiskit sphinx theme.
Details and comments
docs/README.md
(explaination about Diataxis is from https://qiskit.github.io/qiskit_sphinx_theme/intro/diataxis.html)Closes #71
Closes #17