Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add qiskit sphinx theme #72

Merged
merged 12 commits into from
Sep 7, 2023

Conversation

mickahell
Copy link
Contributor

@mickahell mickahell commented Jul 29, 2023

Summary

Use the new qiskit sphinx theme.

Details and comments


Closes #71
Closes #17

Sorry, something went wrong.

@mickahell
Copy link
Contributor Author

mickahell commented Jul 29, 2023

@caleb-johnson @garrison @Eric-Arellano ready for review :)

I had to up the minimal version of python. The qiskit template need sphinx 6 who had a requirement of python >=3.8 (see sphinx package pypi).
Also the python version 3.7.x is depreciated and no longer support by the python team (see latest python 3.7 release info page).

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon the delay! I was OOO. Thanks!

docs/conf.py Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
Co-authored-by: Eric Arellano <[email protected]>
@mickahell
Copy link
Contributor Author

Pardon the delay! I was OOO. Thanks!

Of course no problem, I also was last week ;)

I took your feedbacks and applied them.

@mickahell
Copy link
Contributor Author

I'll also cover the issue #17 ... working on it 🏗️

@mickahell
Copy link
Contributor Author

@garrison @caleb-johnson ready for your review about everything :)

docs/README.md Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
mickahell and others added 2 commits August 14, 2023 20:14
o-authored-by: Eric Arellano <[email protected]>
Co-authored-by: Eric Arellano <[email protected]>
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@mickahell
Copy link
Contributor Author

Awesome work!

Thanks Eric 😃

Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Eric-Arellano and @mickahell !

@caleb-johnson caleb-johnson merged commit 7059fa5 into qiskit-community:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new Qiskit sphinx theme Add docs/README.md file
3 participants