-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin qiskit<1.0 #609
Pin qiskit<1.0 #609
Conversation
9bb0753
to
c187021
Compare
c187021
to
c57673a
Compare
810ef2a
to
b6ecb60
Compare
Pull Request Test Coverage Report for Build 7925995792Details
💛 - Coveralls |
@t-imamichi So a question. I just fixed up tutorials for the algorithms as CI was failing there qiskit-community/qiskit-algorithms#156. Yesterday in Finance a backport failed, it was done just after 1.0 released where the original PR was done with 0.46, and I just fixed them the same way - CI is now failing there the same way as here, now that the tutorials get further qiskit-community/qiskit-finance#331. I need to fix the tutorials here too and that needs backporting - and that would fail unless this is backported too or we just leave that failing on stable for now. The question is do you just want to wait until algorithms is released so this does not have to be merged on main and then reverted in a couple of days. |
@t-imamichi Qiskit Algorithms 0.3.0 has been released so this pinning is no longer needed. The PR fixing the tutorials #610 is now passing, except for test of the stable tutorials which 610 is needed to be backported to fix. |
I am going to close this off since its no longer needed, now that Qiskit Algorithms 0.3.0 has been released. |
Thank you for releasing qiskit-algorithms 0.3.0! |
Summary
CI fails with Qiskit 1.0. https://github.com/qiskit-community/qiskit-optimization/actions/runs/7924881956
This PR is a workaround until qiskit-algorithms 0.3.0 is released.
I locally confirmed that qiskit-optimization main + qiskit-algorithms main + qiskit 1.0 pass all tests.
More specifically, we need qiskit-community/qiskit-algorithms#98.
Details and comments