Bump Mac and Win upper Python version for CI #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsp-ibm
added
stable backport potential
woodsp-ibm
requested review from
stefan-woerner,
t-imamichi,
dthuerck and
Sofranac-Boro
as code owners
Pull Request Test Coverage Report for Build 7888801795Details
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
(cherry picked from commit d36fd45)
woodsp-ibm
added a commit
that referenced
this pull request
Feb 13, 2024
(cherry picked from commit d36fd45) Co-authored-by: Steve Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed, when looking at last nights CI, which had failed (was just due to some network issue where it timed out (re-running the job passed) that for Mac and Windows the job is still using Python 3.10. Normally we test these platforms at the lowest and highest Python level supported but perhaps this was kept at 3.10 as sometimes wheels for these, for the latest version of Python, are longer coming. (All other app repos are doing this at 3.8 and 3.11 so this change will bring Opt in to sync in that respect).
Anyway I updated these so Mac and Windows now test at 3.8 and 3.11, instead of 3.8 and 3.10. I would imagine this should all work by now, but can't check locally.
Details and comments
Assuming this passes it will need the branch rules updated accordingly. I labelled it backport since the last release was not too long ago and this will keep CI in sync there too for any bug fixes etc.