Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions using deprecated Node.js #595

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

woodsp-ibm
Copy link
Member

@woodsp-ibm woodsp-ibm commented Feb 5, 2024

Summary

Currently CI - if you look in the build details Summary - is emitting a bunch of deprecation warnings around actions and Node.js

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

This updates the actions to the latest versions.

Details and comments

I will mark this as stable backport - I think the workflows should backport ok as it has not been long since the last release and it would be better to have them updated as well.

Note: I have updated the actions in the other apps (Nature and ML, as well as Algorithms). I did this manually here for all the actions but intend to add a dependabot config to have it create PRs, when needed in the future for updates. It creates a PR for each action, which is the reason I went ahead and did all actions here as I found out that the upload and download needed to be done together for things to work (it errored finding the file if there was a version mismatch) so I ended up there doing a manual PR anyway to combine the upload and download hence I figured I would have to at least do that here so I may as well do the lot, add the dependabot config afterwards as a separate PR so the updating can have some automation for the future.

@woodsp-ibm woodsp-ibm added stable backport potential The bug might be minimal and/or import enough to be port to stable type: ci Related to CI changes labels Feb 5, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7790004749

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.029%

Totals Coverage Status
Change from base Build 7644653201: 0.0%
Covered Lines: 4511
Relevant Lines: 4849

💛 - Coveralls

Copy link
Collaborator

@t-imamichi t-imamichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 4f8beff into qiskit-community:main Feb 6, 2024
17 checks passed
mergify bot pushed a commit that referenced this pull request Feb 6, 2024
mergify bot added a commit that referenced this pull request Feb 6, 2024
(cherry picked from commit 4f8beff)

Co-authored-by: Steve Wood <[email protected]>
@woodsp-ibm woodsp-ibm deleted the update_actions_versions branch February 6, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge stable backport potential The bug might be minimal and/or import enough to be port to stable type: ci Related to CI changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants