Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used trusted publisher for PyPi #564

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Used trusted publisher for PyPi #564

merged 2 commits into from
Oct 18, 2023

Conversation

woodsp-ibm
Copy link
Member

Summary

This PR follows Qiskit/rustworkx#1001 to update the release CI workflow to use PyPI's trusted publisher mechanism.

Details and comments

@woodsp-ibm woodsp-ibm added on hold Can not fix yet type: ci Related to CI changes labels Oct 12, 2023
@coveralls
Copy link

coveralls commented Oct 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6564898209

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.028%
Totals Coverage Status
Change from base Build 6525029618: 0.0%
Covered Lines: 4510
Relevant Lines: 4848
💛 - Coveralls

mtreinish
mtreinish approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I'm planning to hopefully migrate the pypi account on Wednesday, so as long as you aren't planning any releases before then we can merge this whenever (it only will work after the migration though).

@woodsp-ibm woodsp-ibm added automerge and removed on hold Can not fix yet labels Oct 18, 2023
@mergify mergify bot merged commit 592385e into qiskit-community:main Oct 18, 2023
15 checks passed
@woodsp-ibm woodsp-ibm deleted the pypi branch October 18, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-imamichi t-imamichi t-imamichi approved these changes

@mtreinish mtreinish mtreinish approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner stefan-woerner is a code owner

Assignees
No one assigned
Labels
automerge type: ci Related to CI changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@woodsp-ibm @coveralls @mtreinish @t-imamichi