-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stestr and mypy issues #559
Conversation
@@ -3,7 +3,7 @@ matplotlib>=2.1 | |||
black[jupyter]~=22.0 | |||
pylint>=2.16.2 | |||
pylatexenc>=1.4 | |||
stestr>=2.0.0 | |||
stestr>=4.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is fine - the constraint change that Qiskit did was simply closed. CI pulls in the latest version anyway even with >=2.0.0, but if you had some local older stestr install working this requires things to be updated if you pip install this dev file. Qiskit left their requirements-dev as it was before. I guess if you had things working locally and somehow just updated python-subunit then it would faili if you did not have anything installed then as of now, like CI, it would install 4.1.0 and work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I updated the version because someone may update only python-subunit and have the stestr trouble.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put a comment in there - I think its ok like this but I'll leave it to you.
@t-imamichi I was looking through the combined deprecation messages from the build, as this was the latest. I noticed this which seems related to what you fixed here but elsewhere
|
Thanks for the report. I found a line that uses
|
Summary
Fix "stestr run" error by pinning python-subunit version.Update stestr version that has been just released.
https://github.com/mtreinish/stestr/releases/tag/4.1.0
Fix mypy by modifying colormap access.
I found these errors in the recent scheduled CI.
https://github.com/qiskit-community/qiskit-optimization/actions/runs/6217275395
Details and comments