-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes #558
Minor fixes #558
Conversation
I imagine this is ready since things now pass - you still have WIP in the title. |
Today's schedule CI fails due to the error. |
I also fixed |
Can you fix one other place too - this is a validation function that was used by algos. It will be deprecated/removed from Qiskit and was "moved" to qiskit_algorithms too. qiskit-optimization/qiskit_optimization/algorithms/recursive_minimum_eigen_optimizer.py Line 20 in b5b8de8
(Simply change from qiskit.utils... to from qiskit_algorithms.utils... |
Thanks. I did it. |
For this
the SciPyMilpOptimizer before, and in fact as it still is, is treated as an optional and has conditional logic around that. With bumping the version of scipy that conditional optional logic is not really needed anymore right? Maybe that optional aspect was done more due to the fact that 3.7 was still supported here but SciPy needed 3.8 or above for that version. So bottom line should we get rid of the optional logic there now with this being bumped - its irrelevant after this change. |
Thanks. I forgot about optional. I removed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks. Could you approve it? I then merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my bad - the LGTM comment was supposed to have been an Approve!
Thank you for merging it. |
Summary
Fix mypy error in main branch.
https://github.com/qiskit-community/qiskit-optimization/actions/runs/6172901069
Also fixes following items
ScipyMilpOptimizer
.Details and comments