Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise reno #554

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Revise reno #554

merged 3 commits into from
Sep 11, 2023

Conversation

t-imamichi
Copy link
Collaborator

Summary

Fixes #551

Details and comments

@coveralls
Copy link

coveralls commented Sep 11, 2023

Pull Request Test Coverage Report for Build 6148219903

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.032%

Totals Coverage Status
Change from base Build 6147407641: 0.0%
Covered Lines: 4513
Relevant Lines: 4851

💛 - Coveralls

woodsp-ibm
woodsp-ibm previously approved these changes Sep 11, 2023
Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, LGTM!

@t-imamichi
Copy link
Collaborator Author

Sorry. I checked the PR and notice the removal of from_ising and to_ising might be too much. So, I re-added a simplifed reno about them. Could you take a look at it?

Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, it seems fine. It was covered by this more general statement I thought, but it does not harm to be have that more specific text as well.

The support for Opflow is removed to represent Ising Hamiltonians. Qiskit optimization supports only qiskit.quantum_info.SparsePauliOp, instead.

@t-imamichi
Copy link
Collaborator Author

Thanks. I then merge it.

@mergify mergify bot merged commit 15dfa96 into qiskit-community:main Sep 11, 2023
15 checks passed
@t-imamichi t-imamichi deleted the reno branch September 11, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check over release notes for this release.
3 participants