Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSI4 Driver Update #521

Merged
merged 15 commits into from
Feb 15, 2022
Merged

Conversation

mrossinek
Copy link
Member

Summary

This is a proof-of-concept for the Psi4Driver update with the new HDF5-property integration (#461).

Details and comments

I'm mostly opening this PR to leverage the CI. This is on hold until the HDF5 integration is merged. Once that happens, I will rebase the branch onto main.

@mrossinek mrossinek added the on hold Can not fix yet label Jan 27, 2022
@mrossinek mrossinek self-assigned this Jan 27, 2022
@mrossinek mrossinek force-pushed the psi4_driver_update branch 2 times, most recently from 818af75 to 1bdb727 Compare January 27, 2022 14:32
@coveralls
Copy link

coveralls commented Jan 27, 2022

Pull Request Test Coverage Report for Build 1847251328

  • 18 of 20 (90.0%) changed or added relevant lines in 2 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 82.925%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_nature/drivers/second_quantization/psi4d/psi4driver.py 16 18 88.89%
Files with Coverage Reduction New Missed Lines %
qiskit_nature/drivers/second_quantization/psi4d/psi4driver.py 1 84.43%
qiskit_nature/properties/second_quantization/electronic/electronic_energy.py 1 94.59%
qiskit_nature/drivers/qmolecule.py 7 38.06%
Totals Coverage Status
Change from base Build 1846694836: -0.09%
Covered Lines: 8693
Relevant Lines: 10483

💛 - Coveralls

@mrossinek mrossinek mentioned this pull request Jan 31, 2022
10 tasks
@mrossinek mrossinek marked this pull request as ready for review February 11, 2022 08:27
@mrossinek mrossinek removed the on hold Can not fix yet label Feb 11, 2022
@mrossinek mrossinek mentioned this pull request Feb 12, 2022
The warning did not contain the correct object information.
Furthermore, the non-transformed properties are not actually being
removed but are merely left untransformed.
woodsp-ibm
woodsp-ibm previously approved these changes Feb 14, 2022
pbark
pbark previously approved these changes Feb 15, 2022
Copy link
Contributor

@pbark pbark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mrossinek mrossinek dismissed stale reviews from pbark and woodsp-ibm via aa0eeaa February 15, 2022 08:11
@mrossinek
Copy link
Member Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Feb 15, 2022

refresh

✅ Pull request refreshed

@manoelmarques manoelmarques merged commit 5340a9b into qiskit-community:main Feb 15, 2022
@mrossinek mrossinek deleted the psi4_driver_update branch February 15, 2022 14:46
Anthony-Gandon pushed a commit to Anthony-Gandon/qiskit-nature that referenced this pull request May 25, 2023
* wip: refactor Psi4Driver to integrate property framework

* fix: Psi4Driver.template do not put orbital energies as occupations

* fix: Psi4Driver handle non-dictionary aux_operators

* fix: Psi4Driver path handling in Windows

* fix: always set AngularMomentum and Magnetization

Similar reasoning as in
qiskit-community@fcf140a

* Fix mypy

* fix: update to correct save_to_hdf5 API

* fix: inject runtime config

* fix: import future annotations

* ref: avoid potential variable name clashes in Psi4 template

* fix: ActiveSpaceTransformer warning

The warning did not contain the correct object information.
Furthermore, the non-transformed properties are not actually being
removed but are merely left untransformed.

* Fix after merge

* reset mergify

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Manoel Marques <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants