-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSI4 Driver Update #521
Merged
manoelmarques
merged 15 commits into
qiskit-community:main
from
mrossinek:psi4_driver_update
Feb 15, 2022
Merged
PSI4 Driver Update #521
manoelmarques
merged 15 commits into
qiskit-community:main
from
mrossinek:psi4_driver_update
Feb 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrossinek
force-pushed
the
psi4_driver_update
branch
2 times, most recently
from
January 27, 2022 14:32
818af75
to
1bdb727
Compare
Pull Request Test Coverage Report for Build 1847251328
💛 - Coveralls |
mrossinek
force-pushed
the
psi4_driver_update
branch
from
February 10, 2022 16:31
1bdb727
to
6d23b1b
Compare
mrossinek
requested review from
stefan-woerner,
pbark,
manoelmarques and
woodsp-ibm
as code owners
February 11, 2022 08:27
woodsp-ibm
reviewed
Feb 11, 2022
Merged
The warning did not contain the correct object information. Furthermore, the non-transformed properties are not actually being removed but are merely left untransformed.
woodsp-ibm
previously approved these changes
Feb 14, 2022
pbark
previously approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
pbark
approved these changes
Feb 15, 2022
@Mergifyio refresh |
✅ Pull request refreshed |
Anthony-Gandon
pushed a commit
to Anthony-Gandon/qiskit-nature
that referenced
this pull request
May 25, 2023
* wip: refactor Psi4Driver to integrate property framework * fix: Psi4Driver.template do not put orbital energies as occupations * fix: Psi4Driver handle non-dictionary aux_operators * fix: Psi4Driver path handling in Windows * fix: always set AngularMomentum and Magnetization Similar reasoning as in qiskit-community@fcf140a * Fix mypy * fix: update to correct save_to_hdf5 API * fix: inject runtime config * fix: import future annotations * ref: avoid potential variable name clashes in Psi4 template * fix: ActiveSpaceTransformer warning The warning did not contain the correct object information. Furthermore, the non-transformed properties are not actually being removed but are merely left untransformed. * Fix after merge * reset mergify Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Manoel Marques <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a proof-of-concept for the
Psi4Driver
update with the new HDF5-property integration (#461).Details and comments
I'm mostly opening this PR to leverage the CI. This is
on hold
until the HDF5 integration is merged. Once that happens, I will rebase the branch ontomain
.