-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle orbital overlap in spin operators #1275
Merged
mrossinek
merged 10 commits into
qiskit-community:main
from
mrossinek:spin-square-overlap
Nov 15, 2023
Merged
Handle orbital overlap in spin operators #1275
mrossinek
merged 10 commits into
qiskit-community:main
from
mrossinek:spin-square-overlap
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6866355451
💛 - Coveralls |
mrossinek
requested review from
stefan-woerner and
woodsp-ibm
as code owners
November 14, 2023 14:21
woodsp-ibm
reviewed
Nov 14, 2023
Co-authored-by: Steve Wood <[email protected]>
woodsp-ibm
approved these changes
Nov 14, 2023
woodsp-ibm
added
the
stable backport potential
The bug might be minimal and/or import enough to be port to stable
label
Nov 14, 2023
Do we really want to backport this? It is a significant bug, but this also changes the API of e.g. the |
The change is backward compatible though with any existing code is it not - the new parameter is optional and it will still do what it did before no? But technically it is an API change, though needed to sort the bug. |
mergify bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
* feat: include the overlap in the AngularMomentum Fixes #1273 * test: add unittests for spin operators with overlap * Add reno * Update docs * Add spelling exceptions * Add missing import * Handle overlap in AngularMomentum during transformers * Handle overlap during drivers * Mention new method to extract overlap from QCSchema in reno * Update releasenotes/notes/fix-angular-momentum-73eca0a5afb70679.yaml Co-authored-by: Steve Wood <[email protected]> --------- Co-authored-by: Steve Wood <[email protected]> (cherry picked from commit 0c0b3c8)
mergify bot
added a commit
that referenced
this pull request
Nov 15, 2023
* feat: include the overlap in the AngularMomentum Fixes #1273 * test: add unittests for spin operators with overlap * Add reno * Update docs * Add spelling exceptions * Add missing import * Handle overlap in AngularMomentum during transformers * Handle overlap during drivers * Mention new method to extract overlap from QCSchema in reno * Update releasenotes/notes/fix-angular-momentum-73eca0a5afb70679.yaml Co-authored-by: Steve Wood <[email protected]> --------- Co-authored-by: Steve Wood <[email protected]> (cherry picked from commit 0c0b3c8) Co-authored-by: Max Rossmannek <[email protected]>
ialsina
pushed a commit
to ialsina/qiskit-nature
that referenced
this pull request
Nov 17, 2023
* feat: include the overlap in the AngularMomentum Fixes qiskit-community#1273 * test: add unittests for spin operators with overlap * Add reno * Update docs * Add spelling exceptions * Add missing import * Handle overlap in AngularMomentum during transformers * Handle overlap during drivers * Mention new method to extract overlap from QCSchema in reno * Update releasenotes/notes/fix-angular-momentum-73eca0a5afb70679.yaml Co-authored-by: Steve Wood <[email protected]> --------- Co-authored-by: Steve Wood <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1273. For more details, please refer to that issue.
Details and comments
This is potentially problematic right now, because theQCSchema
does not have a field to specify the overlap. I will need to investigate a good solution for this.QCSchema
which stores the AOoverlap
. This seems like the best solution at this time.AngularMomentum
is handled properly by anyTransformer
class