Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling of Schrödinger in tutorial #1218

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

AbdullahKazi500
Copy link
Contributor

@AbdullahKazi500 AbdullahKazi500 commented Jul 1, 2023

Summary

In the tutorial https://qiskit.org/ecosystem/nature/tutorials/01_electronic_structure.html Schroedinger was wrongly written
The correction of "schroedinger" to "Schrödinger" is important for several reasons. First and foremost, it is about giving proper recognition and respect to the scientist by using the correct spelling of his name.
Furthermore, the correction highlights the significance of Erwin Schrödinger's work in quantum mechanics. His formulation of wave mechanics, which is described by the Schrödinger equation, provided a mathematical framework to describe the behavior of quantum systems. The Schrödinger equation is a fundamental equation in quantum mechanics that describes the time evolution of a quantum state.

University of Oxford https://www-thphys.physics.ox.ac.uk/people/SteveSimon/errors.html
Using an Umlaut over O is conventional and more appropriate

Details and comments

In summary, the correction from "schroedinger" to "Schrödinger" is justified based on proper naming conventions, respect for the individual, accuracy in scientific communication, recognition of historical and scientific significance

@CLAassistant
Copy link

CLAassistant commented Jul 1, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant

This comment was marked as outdated.

@mrossinek mrossinek changed the title Update 01_electronic_structure.ipynb Fix spelling of Schrödinger in tutorial Jul 3, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5433118580

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 85.88%

Totals Coverage Status
Change from base Build 5403052748: 0.009%
Covered Lines: 18587
Relevant Lines: 21643

💛 - Coveralls

Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

Please sign the CLA so that we can merge this.

@AbdullahKazi500
Copy link
Contributor Author

@mrossinek Done

@AbdullahKazi500
Copy link
Contributor Author

I have signed CLA but I guess @mrossinek it is not showing up I don't know why

@woodsp-ibm
Copy link
Member

woodsp-ibm commented Jul 3, 2023

The CLA shows signed in the checks below. Above there are two comments from the CLA, 2 days ago, - one says it not signed, presumably before you signed, and the other says its signed (quite why that one is before the other I am not sure, but I have seen that in the past) - so it does seem to me its signed.

@AbdullahKazi500
Copy link
Contributor Author

Yep I have signed prior to this as well for Translation and other merge

@mrossinek
Copy link
Member

Earlier when I commented both comments were listed as not signed. So your signing definitely registered in one of them.

As to why there are two comments to begin with and one of them does not update is still a mystery to me. We will look into that separately though, regardless of this PR 👍

@mrossinek mrossinek added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Jul 3, 2023
@mrossinek mrossinek merged commit 2d001c8 into qiskit-community:stable/0.6 Jul 3, 2023
@mrossinek
Copy link
Member

Oh I just noticed now that you made this PR against the stable branch and not main.. Will port this to main manually now 👍

mrossinek pushed a commit to mrossinek/qiskit-nature that referenced this pull request Jul 3, 2023
@mrossinek mrossinek mentioned this pull request Jul 3, 2023
mergify bot pushed a commit that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants