-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs #1175
Improve docs #1175
Conversation
Pull Request Test Coverage Report for Build 5054363760
💛 - Coveralls |
FYI. This has an interplay with #1085 where this part in the init file, the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, Steve!
I resolved the interplay after #1085 got merged.
In hindsight, maybe merging in the other order would have been preferable as now this backport will have a minor conflict, but its too late for that now 😅
* Update mergify config * Fix copyright * Update after merging the bosonic operator PR --------- Co-authored-by: Max Rossmannek <[email protected]> (cherry picked from commit 1eec83b) # Conflicts: # qiskit_nature/second_q/mappers/__init__.py
* Improve docs (#1175) * Update mergify config * Fix copyright * Update after merging the bosonic operator PR --------- Co-authored-by: Max Rossmannek <[email protected]> (cherry picked from commit 1eec83b) # Conflicts: # qiskit_nature/second_q/mappers/__init__.py * Resolve merge conflicts --------- Co-authored-by: Steve Wood <[email protected]> Co-authored-by: Max Rossmannek <[email protected]>
* Update mergify config * Fix copyright * Update after merging the bosonic operator PR --------- Co-authored-by: Max Rossmannek <[email protected]>
Summary
Similar to qiskit-community/qiskit-machine-learning#635
Resolves #1055
This changes things here, which used to have a couple of templates where inherited methods was the choice and no inheritence the default, over to inherited methods are shown by default and it has to be selected to suppress them - which presently is just done for circuit library classes inheriting from QuantumCircuit. This is also how Qiskit does things.
It fails locally with make spell for me, as I imagine it pulls stuff in that was not before. But I will let it go through CI here once before changing anything in that regard assuming it fails likewise here.
Locally I had deleted the with_inherited rst template and added a the no_inherited one - but it ended up as a rename and change of contents which is fine.
Details and comments