Pin numpy==1.26.4 for compatibility with torch=2.2.2
#814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torch issue716
edoaltamura
added
type: ci 🔧
edoaltamura
requested review from
woodsp-ibm,
adekusar-drl,
smens,
oscar-wallis,
OkuyanBoga and
Benjamin-Symons
as code owners
edoaltamura
changed the title
numpy==1.26.4 for compatibility with torch=2.2.2numpy~<1.26.4 for compatibility with torch=2.2.2
edoaltamura
changed the title
numpy~<1.26.4 for compatibility with torch=2.2.2numpy==1.26.4 for compatibility with torch=2.2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #812
Patches temporarily the failing CI tests described in #812 by pinning Numpy to a stable version <2.0, compatible with the already pinned PyTorch 2.2.2.
Details and comments
Once pytorch/pytorch#124897 is closed/resolved, both Numpy and PyTorch pinned versions are to be released and normalised to the latest stable releases.