Added max_circuits_per_job and removed deepcopy dependency of the quantum kernel trainer fixing #701 and #600 #772

OkuyanBoga · 2024-02-21T10:12:23Z

Summary

Bug fixes have been made to fix issues #701 and #600.
Changes made:
#701: Added a max_circuits_per_job parameter to fidelity quantum kernel used in the case that if more circuits are submitted than the job limit for the backend, the circuits are split up and ran through separate jobs. Documentation was added and formatted for this.
#600: Removed quantum kernel trainers dependency on copy.deepcopy that was throwing an error with real backends. Now initialise a new instance of a class and assign parameters manually. As change is purely internal, no new documentation required.

Details and comments

All relevant unit tests were run on code.

✅ I have updated the documentation accordingly.
✅ I have read the CONTRIBUTING document.
✅ I have added notes to the CHANGELOG.

…mmunity#701

Number of maximum circuits for backend added to solve qiskit-community#701.

…nternally,-fails-with-runtime-primitives Bug#600 qkt deepcopies kernel internally, fails with runtime primitives

CLAassistant · 2024-02-21T10:12:57Z

All committers have signed the CLA.

coveralls · 2024-02-21T11:34:20Z

Pull Request Test Coverage Report for Build 8062887234

Details

0 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 92.607%

Totals
Change from base Build 8008433818:	0.04%
Covered Lines:	1879
Relevant Lines:	2029

💛 - Coveralls

adekusar-drl

You should add unit tests to cover new features

woodsp-ibm · 2024-02-21T13:11:27Z

As I stated here #701 (comment) the primitive ought to be taking care of this as far as I know. I will check, there has been a change where the circuit now has to be an ISA circuit (already conforms to backend in terms of layout and basis gates) instead of allowing logical circuits. So given such knowledge perhaps the limit is expected to be managed too now.

woodsp-ibm · 2024-02-21T13:13:40Z

Also it only needs one release note that lists two fixes. The issues part is for if the release contains known issues that the user should be aware of and workaround - in this case you are fixing issues/bugs so it just needs a fixes section and both can be be specified in the one release note.

woodsp-ibm · 2024-02-21T16:10:14Z

BTW - you can reference the issues in a way that will close them when this PR is merged. So for instance had you written fixes #701 that would cause that issue to be linked and closed when this PR was merged - the earlier link has the set of keywords that can be used and more info.

…2e5b986c1be.yaml Small release note bugfix

OkuyanBoga · 2024-02-21T18:10:20Z

As I stated here #701 (comment) the primitive ought to be taking care of this as far as I know. I will check, there has been a change where the circuit now has to be an ISA circuit (already conforms to backend in terms of layout and basis gates) instead of allowing logical circuits. So given such knowledge perhaps the limit is expected to be managed too now.

The number of max circuits per job needs to be set in the quantum fidelity kernel for the Max circuits hard limit on the hardware, which I believe would be useful for everyone. I reckon the extended sessions will allow users to continue their jobs to solve the latter issue.

Also it only needs one release note that lists two fixes. The issues part is for if the release contains known issues that the user should be aware of and workaround - in this case you are fixing issues/bugs so it just needs a fixes section and both can be be specified in the one release note.

Sorted, I hope it is better now.

You should add unit tests to cover new features

Added new unit tests to cover them.

test/kernels/test_fidelity_qkernel.py

...senotes/notes/fix-701-max_circuits_per_job-and-600-deepcopy-dependency-e6eda2e5b986c1be.yaml

woodsp-ibm · 2024-02-21T20:23:29Z

I added stable backport potential The bug might be minimal and/or import enough to be port to stable label which will cause the mergify bot to do a PR to backport this to the stable branch. This would be done for critical fixes we would want in bug fix release and these seem like such fixes to have ready there for whenever a bug fix release is done.

…2e5b986c1be.yaml

OkuyanBoga · 2024-02-21T21:10:50Z

I made the requested changes.

adekusar-drl

I see a problem with creating a new instance. In my understanding such an instance may be quite different from the original one.

qiskit_machine_learning/kernels/algorithms/quantum_kernel_trainer.py

...senotes/notes/fix-701-max_circuits_per_job-and-600-deepcopy-dependency-e6eda2e5b986c1be.yaml

adekusar-drl

Looks good to me. Thank you.

edoaltamura

Green light from me too.

…ntum kernel trainer fixing #701 and #600 (#772) * Added an option for num_circuits per job for kernels to fix #701 * Updated documentation and format the style. * Removed deepcopy dependency in quantum_kernel_trainer.py * Added release notes * quick fix for spell test * Added unit tests for max_circuits_per_job * Update fix-701-max_circuits_per_job-and-600-deepcopy-dependency-e6eda2e5b986c1be.yaml Small release note bugfix * Update fix-701-max_circuits_per_job-and-600-deepcopy-dependency-e6eda2e5b986c1be.yaml * Minor modifications for the unit test * Removed copy of TrainableKernel --------- Co-authored-by: oscar-wallis <[email protected]> (cherry picked from commit 2f49e9e)

…ntum kernel trainer fixing #701 and #600 (#772) (#780) * Added an option for num_circuits per job for kernels to fix #701 * Updated documentation and format the style. * Removed deepcopy dependency in quantum_kernel_trainer.py * Added release notes * quick fix for spell test * Added unit tests for max_circuits_per_job * Update fix-701-max_circuits_per_job-and-600-deepcopy-dependency-e6eda2e5b986c1be.yaml Small release note bugfix * Update fix-701-max_circuits_per_job-and-600-deepcopy-dependency-e6eda2e5b986c1be.yaml * Minor modifications for the unit test * Removed copy of TrainableKernel --------- Co-authored-by: oscar-wallis <[email protected]> (cherry picked from commit 2f49e9e) Co-authored-by: M. Emre Sahin <[email protected]>

OkuyanBoga and others added 8 commits February 13, 2024 09:49

Added an option for num_circuits per job for kernels to fix qiskit-co…

941ff1e

…mmunity#701

Updated documentation and format the style.

145ec47

Merge pull request #6 from OkuyanBoga/bug/701-num-circuits

6bcbe5f

Number of maximum circuits for backend added to solve qiskit-community#701.

Merge branch 'qiskit-community:main' into sprint-merge-v1

9ab6729

Removed deepcopy dependency in quantum_kernel_trainer.py

6042e8a

Merge pull request #8 from OkuyanBoga/Bug#600-qkt-deepcopies-kernel-i…

858f42b

…nternally,-fails-with-runtime-primitives Bug#600 qkt deepcopies kernel internally, fails with runtime primitives

Merge branch 'qiskit-community:main' into sprint-merge-v1

dfd8708

Added release notes

e304afa

OkuyanBoga requested review from woodsp-ibm, adekusar-drl, smens, edoaltamura, oscar-wallis and Benjamin-Symons as code owners February 21, 2024 10:12

quick fix for spell test

6494cbd

OkuyanBoga mentioned this pull request Feb 21, 2024

The FidelityQuantumKernel cannot be executed on the hardware for larger problems. #701

Closed

adekusar-drl reviewed Feb 21, 2024

View reviewed changes

OkuyanBoga and others added 2 commits February 21, 2024 17:38

Added unit tests for max_circuits_per_job

ce85ad5

Update fix-701-max_circuits_per_job-and-600-deepcopy-dependency-e6eda…

9c00c7a

…2e5b986c1be.yaml Small release note bugfix

woodsp-ibm reviewed Feb 21, 2024

View reviewed changes

test/kernels/test_fidelity_qkernel.py Outdated Show resolved Hide resolved

woodsp-ibm reviewed Feb 21, 2024

View reviewed changes

...senotes/notes/fix-701-max_circuits_per_job-and-600-deepcopy-dependency-e6eda2e5b986c1be.yaml Outdated Show resolved Hide resolved

woodsp-ibm added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Feb 21, 2024

OkuyanBoga closed this Feb 21, 2024

OkuyanBoga deleted the sprint-merge-v1 branch February 21, 2024 20:50

OkuyanBoga restored the sprint-merge-v1 branch February 21, 2024 20:50

OkuyanBoga and others added 2 commits February 21, 2024 20:56

Update fix-701-max_circuits_per_job-and-600-deepcopy-dependency-e6eda…

ff202fe

…2e5b986c1be.yaml

Minor modifications for the unit test

c330f79

OkuyanBoga reopened this Feb 21, 2024

adekusar-drl reviewed Feb 21, 2024

View reviewed changes

qiskit_machine_learning/kernels/algorithms/quantum_kernel_trainer.py Outdated Show resolved Hide resolved

...senotes/notes/fix-701-max_circuits_per_job-and-600-deepcopy-dependency-e6eda2e5b986c1be.yaml Outdated Show resolved Hide resolved

OkuyanBoga and others added 2 commits February 26, 2024 09:15

Merge branch 'qiskit-community:main' into sprint-merge-v1

fc56eae

Removed copy of TrainableKernel

91ea747

OkuyanBoga changed the title ~~Fix #701 max_circuits_per_job and #600 deepcopy dependency.~~ Added max_circuits_per_job and removed deepcopy dependency of the quantum kernel trainer fixing #701 and #600 Feb 27, 2024

declanmillar self-requested a review February 29, 2024 15:06

adekusar-drl approved these changes Feb 29, 2024

View reviewed changes

OkuyanBoga merged commit 2f49e9e into qiskit-community:main Feb 29, 2024
16 checks passed

edoaltamura approved these changes Feb 29, 2024

View reviewed changes

mergify bot mentioned this pull request Feb 29, 2024

Added max_circuits_per_job and removed deepcopy dependency of the quantum kernel trainer fixing #701 and #600 (backport #772) #780

Merged

OkuyanBoga deleted the sprint-merge-v1 branch March 18, 2024 14:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added max_circuits_per_job and removed deepcopy dependency of the quantum kernel trainer fixing #701 and #600 #772

Added max_circuits_per_job and removed deepcopy dependency of the quantum kernel trainer fixing #701 and #600 #772

OkuyanBoga commented Feb 21, 2024

CLAassistant commented Feb 21, 2024 •

edited

Loading

coveralls commented Feb 21, 2024 •

edited

Loading

adekusar-drl left a comment

woodsp-ibm commented Feb 21, 2024

woodsp-ibm commented Feb 21, 2024

woodsp-ibm commented Feb 21, 2024 •

edited

Loading

OkuyanBoga commented Feb 21, 2024

woodsp-ibm commented Feb 21, 2024

OkuyanBoga commented Feb 21, 2024

adekusar-drl left a comment

adekusar-drl left a comment

edoaltamura left a comment

Added max_circuits_per_job and removed deepcopy dependency of the quantum kernel trainer fixing #701 and #600 #772

Added max_circuits_per_job and removed deepcopy dependency of the quantum kernel trainer fixing #701 and #600 #772

Conversation

OkuyanBoga commented Feb 21, 2024

Summary

Details and comments

CLAassistant commented Feb 21, 2024 • edited Loading

coveralls commented Feb 21, 2024 • edited Loading

Pull Request Test Coverage Report for Build 8062887234

Details

💛 - Coveralls

adekusar-drl left a comment

Choose a reason for hiding this comment

woodsp-ibm commented Feb 21, 2024

woodsp-ibm commented Feb 21, 2024

woodsp-ibm commented Feb 21, 2024 • edited Loading

OkuyanBoga commented Feb 21, 2024

woodsp-ibm commented Feb 21, 2024

OkuyanBoga commented Feb 21, 2024

adekusar-drl left a comment

Choose a reason for hiding this comment

adekusar-drl left a comment

Choose a reason for hiding this comment

edoaltamura left a comment

Choose a reason for hiding this comment

CLAassistant commented Feb 21, 2024 •

edited

Loading

coveralls commented Feb 21, 2024 •

edited

Loading

woodsp-ibm commented Feb 21, 2024 •

edited

Loading