Remove all other languages other than Spanish and Japanese #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spanish and Japanese are the only languages that was 100% translated & proofread as of Jan 2024
Eric-Arellano
approved these changes
Feb 15, 2024
Pull Request Test Coverage Report for Build 7918523332Details
💛 - Coveralls |
SooluThomas
requested review from
woodsp-ibm,
adekusar-drl,
smens,
edoaltamura,
oscar-wallis,
OkuyanBoga and
Benjamin-Symons
as code owners
|
This just basically removes them from being selected from the dropdown right - the translated pages (locales) will still be there, unless removed, from the gh_pages branch where all this is published - so if you know you could still alter the url and see things if this is all that is changed. Or are well also going to delete the other locales, ie all apart from Spanish and Japanese, in gh_pages too? |
I think that's fine. There isn't much downside. There's also an upside that it will make sure we don't 404 for old Google results for the translated docs that used to be hosted on qiskit.org and now redirect. |
woodsp-ibm
added
stable backport potential
woodsp-ibm
approved these changes
Feb 15, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
Spanish and Japanese are the only languages that was 100% translated & proofread as of Jan 2024 (cherry picked from commit 91e6e0b)
mergify bot
added a commit
that referenced
this pull request
Feb 15, 2024
Spanish and Japanese are the only languages that was 100% translated & proofread as of Jan 2024 (cherry picked from commit 91e6e0b) Co-authored-by: Soolu Thomas <[email protected]>
This was referenced Feb 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Spanish and Japanese are the only languages that was 100% translated & proofread as of Jan 2024
Details and comments