Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sphinx theme #693

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Update Sphinx theme #693

merged 5 commits into from
Oct 16, 2023

Conversation

arnaucasau
Copy link
Contributor

@arnaucasau arnaucasau commented Sep 28, 2023 •
edited
Loading

Summary

Updates to new Ecosystem theme.

Total file size increased (9.53 MB -> 9.79 MB)
index.html size increased (22 KB → 39.5 KB)
Build time increased (46s → 59s)

For more information: Qiskit/qiskit_sphinx_theme#232

@woodsp-ibm
Copy link
Member

Failure in CI was unrelated to this change, which I just fixed in #694. hence I updated here after it was merged.

@arnaucasau
Copy link
Contributor Author

Perfect! Thank you so much @woodsp-ibm

@coveralls
Copy link

coveralls commented Sep 29, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6534648959

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.689%
Totals Coverage Status
Change from base Build 6508861060: 0.0%
Covered Lines: 1851
Relevant Lines: 1997
💛 - Coveralls

@arnaucasau arnaucasau mentioned this pull request Oct 11, 2023
Merged
@woodsp-ibm
Copy link
Member

Similar comment to that I made in the similar PR to Optimization

In Qiskit Nature I note that you changed SubModule heading level - presumably so SubModule does not come out in left navigation sidebar.

I see there are a couple of places in ML here

@arnaucasau arnaucasau marked this pull request as ready for review October 16, 2023 14:36
woodsp-ibm
woodsp-ibm approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx!

@mergify mergify bot merged commit 17a6f85 into qiskit-community:main Oct 16, 2023
15 checks passed
oscar-wallis pushed a commit that referenced this pull request Feb 16, 2024
@arnaucasau @frankharkins @woodsp-ibm
Update Sphinx theme (#693)
72c58fc 
* Update Sphinx theme

Co-authored-by: Frank Harkins <[email protected]>

* Fix docs heading levels

---------

Co-authored-by: Frank Harkins <[email protected]>
Co-authored-by: Steve Wood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner

@adekusar-drl adekusar-drl Awaiting requested review from adekusar-drl adekusar-drl is a code owner

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnaucasau @woodsp-ibm @coveralls