Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FakeToronto import and Fix Aer Deprecate Messages #424

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

manoelmarques
Copy link
Contributor

@manoelmarques manoelmarques commented Jun 24, 2022

Summary

Change FakeToronto import, fix Aer deprecate messages, all due to recent Terra changes.

Related to Qiskit/qiskit#8121 and Qiskit/qiskit#5089

Details and comments

@manoelmarques manoelmarques added the type: ci 🔧 Related to Continuous Integration workflows label Jun 24, 2022
@manoelmarques manoelmarques self-assigned this Jun 24, 2022
@manoelmarques manoelmarques force-pushed the mock branch 4 times, most recently from dedb679 to 9238ccb Compare June 24, 2022 02:14
@manoelmarques manoelmarques changed the title Fix FakeToronto import Fix FakeToronto import and Fix Aer Deprecate Messages Jun 24, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2553174602

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 86.995%

Files with Coverage Reduction New Missed Lines %
qiskit_machine_learning/datasets/gaussian.py 3 37.11%
Totals Coverage Status
Change from base Build 2533113391: -0.09%
Covered Lines: 3017
Relevant Lines: 3468

💛 - Coveralls

Copy link
Collaborator

@adekusar-drl adekusar-drl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have references to the changes in Terra.

@manoelmarques manoelmarques merged commit 505495f into qiskit-community:main Jun 24, 2022
@manoelmarques manoelmarques deleted the mock branch June 24, 2022 12:04
@manoelmarques manoelmarques added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Aug 10, 2022
mergify bot pushed a commit that referenced this pull request Aug 10, 2022
(cherry picked from commit 505495f)

# Conflicts:
#	test/algorithms/classifiers/test_neural_network_classifier.py
#	test/algorithms/classifiers/test_vqc.py
#	test/algorithms/regressors/test_neural_network_regressor.py
#	test/neural_networks/test_two_layer_qnn.py
mergify bot added a commit that referenced this pull request Aug 10, 2022
…#451)

* Fix FakeToronto import (#424)

(cherry picked from commit 505495f)

# Conflicts:
#	test/algorithms/classifiers/test_neural_network_classifier.py
#	test/algorithms/classifiers/test_vqc.py
#	test/algorithms/regressors/test_neural_network_regressor.py
#	test/neural_networks/test_two_layer_qnn.py

* fix conflicts

Co-authored-by: Manoel Marques <[email protected]>
oscar-wallis pushed a commit that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high stable backport potential The bug might be minimal and/or import enough to be port to stable type: ci 🔧 Related to Continuous Integration workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants