Refactor RawFeatureVector to fix compositions #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
requested review from
manoelmarques,
pbark,
stefan-woerner and
woodsp-ibm
as code owners
stefan-woerner
approved these changes
Mar 29, 2021
This was referenced Mar 31, 2021
gentinettagian
pushed a commit
to gentinettagian/qiskit-machine-learning
that referenced
this pull request
Dec 14, 2021
* fix name clash on _parameters * refactor raw feature vector * add test and fix append case * rm unused import Co-authored-by: Manoel Marques <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the RawFeatureVector to move binding from the circuit object to the underlying instruction. Since the instruction is the object appended to other circuits, we can now compose the RawFeatureVector into other objects while preserving the ability to bind the parameterized initialization later on.