Fix tomography analysis for asymmetric QPT #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug with process tomography performed on a different number of input and output qubits where the target channel and TP condition was not calculated correctly when the dimensions of the input and output fitted channel are different. Also cleans up some TomographyAnalysis helper functions for postprocessing fitter data.
chriseclectic
added
the
Changelog: Bugfix
nkanazawa1989
approved these changes
Apr 1, 2022
paco-ri
pushed a commit
to paco-ri/qiskit-experiments
that referenced
this pull request
Jul 11, 2022
This fixes a bug with process tomography performed on a different number of input and output qubits where the target channel and TP condition was not calculated correctly when the dimensions of the input and output fitted channel are different. Also cleans up some TomographyAnalysis helper functions for postprocessing fitter data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #757
Fixes #758
This fixes a bug with process tomography performed on a different number of input and output qubits where the target channel and TP condition was not calculated correctly when the dimensions of the input and output fitted channel are different.
Also cleans up some TomographyAnalysis helper functions for postprocessing fitter data.
Details and comments
See issues #757, #758 for details.