-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restless measurements data processing nodes #678
Merged
Merged
Changes from 17 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6e067b3
Added restless nodes and tests.
catornow dc6f09f
Merge branch 'main' into RestlessNodes
catornow 1161839
Undid unintentional signature change
catornow c07cf79
Small modification
catornow bc2c496
Improved docstring to avoid redundancies for future restless nodes
catornow 5cba16c
Simplified reorder method using transpose and flatten
catornow ca56109
Added additional arg that specifies in which order the shots are meas…
catornow cd62f0e
Fixed lint errors
catornow 8a7ed24
Modified doc string
catornow beb8d33
Removed print
catornow 566eda4
Merge branch 'main' into RestlessNodes
catornow 0c0116d
Update qiskit_experiments/data_processing/nodes.py
catornow 5e1a2e3
Update qiskit_experiments/data_processing/nodes.py
catornow a156bd8
Update qiskit_experiments/data_processing/nodes.py
catornow f7ae36b
Update qiskit_experiments/data_processing/nodes.py
catornow af25048
Implemented Daniel's suggestion
catornow fe8a45c
Black
catornow 07e777f
Implemented memory_allocation arg
catornow 975c9d7
Lint error
catornow 6ab5760
Black
catornow 12c21b5
Added some documentation
catornow ce042f6
Merge branch 'main' into RestlessNodes
catornow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename
circuit_first
tomemory_allocation
taking value"C"
(circuit-first),"S"
(shot-first) and show a both data structures in class documentation with these labels? Currently only circuit first is shown and user may get wrong impression that the node only supports circuit-first. This memory representation convention would be useful when we implement another type of data processor, i.e. such label can be attached to metadata.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. We could make this convention more explicit with an
Enum
to add proper documentation. Perhaps:and then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I implemented the code here: 07e777f.