Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local and correlated readout error characterization experiments #611

Merged
merged 38 commits into from
Feb 17, 2022
Merged

Local and correlated readout error characterization experiments #611

merged 38 commits into from
Feb 17, 2022

Conversation

gadial
Copy link
Contributor

@gadial gadial commented Jan 16, 2022

Summary

Details and comments

@gadial gadial mentioned this pull request Jan 16, 2022
Merged
@gadial gadial changed the title Mitigation class documentation improvements [WIP] Mitigation class documentation improvements Jan 16, 2022
@gadial gadial changed the title [WIP] Mitigation class documentation improvements Mitigation class documentation improvements Jan 18, 2022
yaelbh
yaelbh reviewed Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@yaelbh yaelbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Chris says: "It doesn't include a release note saying that a new experiment was added with links to the API docs." Did you do it? I somehow don't see it.
  2. Please verify that it runs well on a real device.

docs/tutorials/readout_mitigation.ipynb Outdated Show resolved Hide resolved
qiskit_experiments/library/characterization/__init__.py Outdated Show resolved Hide resolved
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py Outdated Show resolved Hide resolved
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py Outdated Show resolved Hide resolved
docs/tutorials/readout_mitigation.ipynb Outdated Show resolved Hide resolved
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py Outdated Show resolved Hide resolved
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py Show resolved Hide resolved
qiskit_experiments/library/characterization/analysis/local_readout_error_analysis.py Outdated Show resolved Hide resolved
test/test_readout_error.py Show resolved Hide resolved
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py
qubits = experiment_data.metadata["physical_qubits"]
labels = [datum["metadata"]["label"] for datum in data]
matrix = self._generate_matrix(data, labels)
result_mitigator = CorrelatedReadoutMitigator(matrix, qubits=qubits)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that trying to save the experiment will crash because CorrelatedReadoutMitigator is not serializable.

  1. Is this correct?
  2. Verify that you can save with analysis parameter set to False, and you can load it and see it on the web.
  3. Can we do anything that will allow us to save the result?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make these serializable we would to add settings or __json_encode__ method to them for the json serializer. We could monkey patch them in experiments to do this to make it work before they can be added to terra.

chriseclectic
chriseclectic requested changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@chriseclectic chriseclectic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really nice! Several comments for some small tweaks and changes

docs/tutorials/readout_mitigation.ipynb Outdated Show resolved Hide resolved
docs/tutorials/readout_mitigation.ipynb Outdated Show resolved Hide resolved
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py Outdated Show resolved Hide resolved
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py Show resolved Hide resolved
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py Outdated Show resolved Hide resolved
qiskit_experiments/library/characterization/local_readout_error.py Outdated Show resolved Hide resolved
qiskit_experiments/library/characterization/local_readout_error.py Outdated Show resolved Hide resolved
qiskit_experiments/library/characterization/local_readout_error.py Outdated Show resolved Hide resolved
qiskit_experiments/library/characterization/local_readout_error.py Outdated Show resolved Hide resolved
qiskit_experiments/library/characterization/local_readout_error.py Outdated Show resolved Hide resolved
@chriseclectic chriseclectic changed the title Mitigation class documentation improvements Local and correlated readout error characterization experiments Jan 20, 2022
@chriseclectic
Copy link
Collaborator

Forgot to add that the previous release note should be edited to include the two new experiments.

@jakelishman jakelishman mentioned this pull request Jan 24, 2022
Merged
gadial added 16 commits February 13, 2022 08:43
@gadial
Fix the release notes
15ee74f
@gadial
Merge branch 'main' into mitigation_experiment_improvements
8923a07 
# Conflicts:
#	qiskit_experiments/library/__init__.py
#	qiskit_experiments/library/characterization/__init__.py
#	qiskit_experiments/library/characterization/analysis/__init__.py
#	qiskit_experiments/library/mitigation/mitigation_experiment.py
@gadial
Merge branch 'main' into mitigation_experiment_improvements
8359bc0
@gadial
Additional doc fixes according to the PR reviews
c154374
@gadial
Linting
3dd1a25
@gadial
Linting
afa33f8
@gadial
Added a test for db integration
d9069ba
@gadial
Few more doc fixes
c1ad8e1
@gadial
docs fix
dad27bd
@gadial
Specific mitigator serialization hack
6eabbd2
@gadial
Merge branch 'main' into mitigation_experiment_improvements
2952da3
@gadial
Testing mitigator to json encoding/decoding
8ee9eea
@gadial
Merge branch 'main' into mitigation_experiment_improvements
f7c9a74 
# Conflicts:
#	docs/tutorials/readout_mitigation.ipynb
@gadial
Linting
1e4ee4b
@gadial
New version of the mitigation tutorial
09bb213
@gadial
Name change according to the changes in terra
ed1177a
chriseclectic
chriseclectic approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@chriseclectic chriseclectic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chriseclectic chriseclectic merged commit 317b964 into qiskit-community:main Feb 17, 2022
@gadial gadial deleted the mitigation_experiment_improvements branch February 18, 2022 06:31
@chriseclectic chriseclectic added the Changelog: New Feature Include in the "Added" section of the changelog label Apr 25, 2022
paco-ri pushed a commit to paco-ri/qiskit-experiments that referenced this pull request Jul 11, 2022
@gadial
Local and correlated readout error characterization experiments (qisk…
0d1d06a 
…it-community#611)

Added two new experiments LocalReadoutError and CorrelatedReadoutError for characterizing the readout error of devices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaelbh yaelbh yaelbh left review comments

@jakelishman jakelishman jakelishman left review comments

@chriseclectic chriseclectic chriseclectic approved these changes

Assignees
No one assigned
Labels
Changelog: New Feature Include in the "Added" section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gadial @chriseclectic @jakelishman @yaelbh