Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove premature release notes related to MirrorRB #1479

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

wshanks
Copy link
Collaborator

@wshanks wshanks commented Oct 31, 2024

Notes about MirrorRB and BaseSampler were accidentally committed into the version 0.5 release notes, though the actual MirrorRB experiment has not been added so far.

Notes about `MirrorRB` and `BaseSampler` were accidentally committed
into the version 0.5 release notes, though the actual `MirrorRB`
experiment has not been added so far.
@wshanks wshanks requested a review from coruscating October 31, 2024 13:11
Copy link
Collaborator

@coruscating coruscating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! Do you want to backport and rebuild the earlier docs as well?

@wshanks wshanks added the backport stable potential The issue or PR might be minimal and/or import enough to backport to stable label Nov 1, 2024
@wshanks wshanks added this pull request to the merge queue Nov 1, 2024
@wshanks
Copy link
Collaborator Author

wshanks commented Nov 1, 2024

That sounds good. I added the backport label now. That will get the change into the 0.8 release branch. How do you update the docs without making a new tag and triggering a new release? I think we could add a dummy tag to trigger the CI and that would update the docs while leaving PyPI alone (because there is already a version 0.8.0), but is there a better way?

Merged via the queue into qiskit-community:main with commit c66db6f Nov 1, 2024
10 checks passed
@coruscating
Copy link
Collaborator

@wshanks You should be able to directly trigger a Docs Publish run off of a stable branch without having to change anything.

@wshanks wshanks deleted the mirrorrb-note branch November 1, 2024 13:30
@wshanks
Copy link
Collaborator Author

wshanks commented Nov 1, 2024

Do you think we lost mergify with the move to qiskit-community? I don't see a backport PR.

@coruscating
Copy link
Collaborator

coruscating commented Nov 1, 2024

Looks like there are multiple issues here: mergify is gone, the post-release PR hasn't been made to bump the package and mergify versions (like #1460), and stable/0.8 doesn't exist because the release bot didn't trigger.

@wshanks
Copy link
Collaborator Author

wshanks commented Nov 1, 2024

Okay, I added stable/0.8 and opened #1480 to bump the versions. Mergify should be enabled now. We can try toggling the backport label on this PR after the version bump is merged.

@wshanks wshanks added backport stable potential The issue or PR might be minimal and/or import enough to backport to stable and removed backport stable potential The issue or PR might be minimal and/or import enough to backport to stable labels Nov 1, 2024
mergify bot pushed a commit that referenced this pull request Nov 1, 2024
Notes about `MirrorRB` and `BaseSampler` were accidentally committed
into the version 0.5 release notes, though the actual `MirrorRB`
experiment has not been added so far.

(cherry picked from commit c66db6f)
wshanks added a commit that referenced this pull request Nov 1, 2024
…1481)

Notes about `MirrorRB` and `BaseSampler` were accidentally committed
into the version 0.5 release notes, though the actual `MirrorRB`
experiment has not been added so far.<hr>This is an automatic backport
of pull request #1479 done by [Mergify](https://mergify.com).

Co-authored-by: Will Shanks <[email protected]>
@wshanks
Copy link
Collaborator Author

wshanks commented Nov 1, 2024

All taken care of now. Mergify opened the backport PR and the updated docs were deployed by triggering the workflow on the updated stable/0.8 branch. Thanks, @coruscating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable potential The issue or PR might be minimal and/or import enough to backport to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants