Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to SamplerV2 support #1472

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

wshanks
Copy link
Collaborator

@wshanks wshanks commented Oct 12, 2024

  • Patch ExperimentData.completion_times to handle Job.time_per_step not
    existing
  • Pass noise_model run option through to Sampler
  • Add support for level 1 data to Sampler execution
  • Handle case where the Sampler strips circuit metadata from results
  • Mark some test backends as simulators so the sampler does not try to
    validate circuits
  • Change some tests to be more consistent about shots since the Sampler
    can not handle the requested number of shots differing from the shots
    in the actual results.
  • Support level 2 bitstrings in MockIQBackend
  • Fix PulseBackend returning data as numpy array instead of a list
  • Pass run options through to backend in T2HahnBackend
  • Do not set block_for_results timeout to 0 when TEST_TIMEOUT is 0
    (TEST_TIMEOUT=0 indicates no timeout, not immediate timeout).
  • Monkey-patch BackendSamplerV2's run circuits function in the tests so
    that it does not strip circuit metadata that the test backends need to
    generate results.
  • Fix inconsistency between bitstring format and number of qubits in
    restless test.
  • Handle case where job class does not have error_message

* Patch ExperimentData.completion_times to handle Job.time_per_step not
  existing
* Pass noise_model run option through to Sampler
* Add support for level 1 data to Sampler execution
* Handle case where the Sampler strips circuit metadata from results
* Mark some test backends as simulators so the sampler does not try to
  validate circuits
* Change some tests to be more consistent about shots since the Sampler
  can not handle the requested number of shots differing from the shots
in the actual results.
* Support level 2 bitstrings in MockIQBackend
* Fix PulseBackend returning data as numpy array instead of a list
* Pass run options through to backend in T2HahnBackend
* Do not set block_for_results timeout to 0 when TEST_TIMEOUT is 0
  (TEST_TIMEOUT=0 indicates no timeout, not immediate timeout).
* Monkey-patch BackendSamplerV2's run circuits function in the tests so
  that it does not strip circuit metadata that the test backends need to
generate results.
* Fix inconsistency between bitstring format and number of qubits in
  restless test.
@wshanks wshanks requested a review from dcmckayibm October 12, 2024 13:16
@wshanks
Copy link
Collaborator Author

wshanks commented Oct 12, 2024

This is not enough to get the tests to pass. Additional changes are needed to qiskit-ibm-runtime and qiskit in order to support level 1 results in BackendSamplerV2 and to pass a noise model run option through an Aer backend with BackendSamplerV2.

@dcmckayibm dcmckayibm merged commit fcb43dc into qiskit-community:primitives_add Oct 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants