Fix broken codes #1465
Merged
Fix broken codes #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkanazawa1989
added
the
Changelog: Bugfix
nkanazawa1989
commented
Jun 20, 2024
| @@ -169,7 +169,7 @@ by a variant of the Hahn-echo pulse sequence [5]_. | |||
| "formatter.label_offset.pulse_name": 0.1, | |||
| "formatter.text_size.annotate": 14, | |||
| } | |||
| ram_x_schedule.draw(time_range=(0, 1600), style=IQXSimple(**opt), backend=backend) | |||
| ram_x_schedule.draw(time_range=(0, 1600), style=IQXSimple(**opt)) | |||
There was a problem hiding this comment.
this backend (switched to V2) is removed because of Qiskit/qiskit#12608
coruscating
approved these changes
Aug 13, 2024
coruscating
pushed a commit
to coruscating/qiskit-experiments
that referenced
this pull request
Aug 13, 2024
### Summary There were several changes in dependent packages that broke unit test of this package. This PR fixes broken code. ### Details and comments 188eb5c, 83fecce After Qiskit >= 1.2, a protected member `_parameter_table` of the QuantumCircuit is managed in the Rust domain as a part of `CircuitData` and we cannot directly touch this object from Python, though we should continue to support <= 1.1. These commits add attribute check before copying the table. (edit) f372eb3 qiskit-ibm-runtime 0.24 was released and deprecation for V1 backends were added. We should switch to V2 backends. Also some property value has been changed in one of our reference backends. ba2bdce Again, due to the data model update of QuantumCircuit in Qiskit core, a custom circuit equality function used in a unit test was broken. This commit changes approach of the test so that it doesn't need to rely on the custom function.
coruscating
added a commit
that referenced
this pull request
Aug 13, 2024
Co-authored-by: Naoki Kanazawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were several changes in dependent packages that broke unit test of this package. This PR fixes broken code.
Details and comments
188eb5c, 83fecce
After Qiskit >= 1.2, a protected member
_parameter_tableof the QuantumCircuit is managed in the Rust domain as a part ofCircuitDataand we cannot directly touch this object from Python, though we should continue to support <= 1.1. These commits add attribute check before copying the table.(edit)
f372eb3
qiskit-ibm-runtime 0.24 was released and deprecation for V1 backends were added. We should switch to V2 backends. Also some property value has been changed in one of our reference backends.
ba2bdce
Again, due to the data model update of QuantumCircuit in Qiskit core, a custom circuit equality function used in a unit test was broken. This commit changes approach of the test so that it doesn't need to rely on the custom function.