Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version string in stable docs deploy CI #1462

Merged

Conversation

coruscating
Copy link
Collaborator

@coruscating coruscating commented Jun 5, 2024

This PR replaces the buggy git describe command, which doesn't register the updated version when doing a release, with the version in VERSION.txt. We should test that this works by re-running the stable docs deploy on main afterwards. Edit: maybe not since this would build to stable/0.8 right now after the version bump.

@coruscating coruscating added the backport stable potential The issue or PR might be minimal and/or import enough to backport to stable label Jun 5, 2024
@coruscating coruscating requested a review from nkanazawa1989 June 5, 2024 21:05
Copy link
Collaborator

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great! Thanks @coruscating (indeed this release was complicated due to this trouble). So basically we'll keep fingers crossed until next release?

@coruscating
Copy link
Collaborator Author

@nkanazawa1989 To avoid release day troubles next time, I think we can still try running the stable docs CI on main if we don't mind https://qiskit-extensions.github.io/qiskit-experiments/stable/0.8/index.html becoming populated with the 0.7 docs. Maybe it's ok since it's not linked anywhere. Otherwise we can cross our fingers.

@coruscating coruscating added this pull request to the merge queue Jun 6, 2024
Merged via the queue into qiskit-community:main with commit b07645f Jun 6, 2024
11 checks passed
mergify bot pushed a commit that referenced this pull request Jun 6, 2024
This PR replaces the buggy `git describe` command, which doesn't
register the updated version when doing a release, with the version in
`VERSION.txt`. We should test that this works by re-running the stable
docs deploy on `main` afterwards. Edit: maybe not since this would build
to `stable/0.8` right now after the version bump.

(cherry picked from commit b07645f)
coruscating added a commit that referenced this pull request Aug 13, 2024
This PR replaces the buggy `git describe` command, which doesn't
register the updated version when doing a release, with the version in
`VERSION.txt`. We should test that this works by re-running the stable
docs deploy on `main` afterwards. Edit: maybe not since this would build
to `stable/0.8` right now after the version bump.<hr>This is an
automatic backport of pull request #1462 done by
[Mergify](https://mergify.com).

Co-authored-by: Helena Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable potential The issue or PR might be minimal and/or import enough to backport to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants