Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a patched qiskit-ibm-runtime when testing Qiskit main #1389

Merged

Conversation

wshanks
Copy link
Collaborator

@wshanks wshanks commented Feb 3, 2024

This change runs the Qiskit main branch tests against a fork of Qiskit runtime with some Qiskit<1 code (and the qiskit-ibm-provider dependency) removed. It can be undone once qiskit-ibm-runtime releases a version compatible with Qiskit 1.0.

@wshanks wshanks force-pushed the patch-runtime-no-provider branch 2 times, most recently from 7088fea to 594de20 Compare February 3, 2024 13:03
@wshanks
Copy link
Collaborator Author

wshanks commented Feb 3, 2024

This PR depends on #1384. Only the last commit is new. It changes the qiskit-ibm-runtime dependency to a fork I made. Here are the changes I had to make on top of qiskit-ibm-runtime's current main branch. These changes were partly just patching out code we didn't need so we wouldn't get import errors (they are not the way qiskit-ibm-runtime should actually be updated for Qiskit 1.0).

@wshanks wshanks force-pushed the patch-runtime-no-provider branch from 594de20 to 5f0a1a2 Compare February 3, 2024 17:50
@wshanks wshanks marked this pull request as ready for review February 3, 2024 17:50
@wshanks wshanks requested a review from coruscating February 3, 2024 17:51
Copy link
Collaborator

@coruscating coruscating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The tests pass against Qiskit main, but I think docs-qiskit-main needs the same changes.

Copy link
Collaborator

@coruscating coruscating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coruscating coruscating added this pull request to the merge queue Feb 5, 2024
Merged via the queue into qiskit-community:main with commit 00faf96 Feb 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants