Figure extraction from experiment data by name without extension #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItamarGoldman
changed the title
ItamarGoldman
changed the title
yaelbh
reviewed
Oct 23, 2023
releasenotes/notes/access_figure_without_extension-5b7438c19e223d6b.yaml
Outdated
Show resolved
Hide resolved
yaelbh
approved these changes
Oct 23, 2023
Co-authored-by: Yael Ben-Haim <[email protected]>
nkanazawa1989
pushed a commit
to nkanazawa1989/qiskit-experiments
that referenced
this pull request
Jan 10, 2024
…kit-community#1287) ### Summary Figure names could be referred without ".svg" at the ending. ### Details and comments Some details that should be in this section include: In qiskit-community#629 , an issue was raised where a figure that was saved with the name "abcd" couldn't be accessed. This issue is caused by that the 'add_figures()' method in `ExperimentData` class added ".svg" automatically. As it explicitly written that SVG extension is added if the file name doesn't have one, we can conclude that all figure names have ".svg" extension. To not make a major change in the code I added to the `figure` method in `ExperimentData` class a check for the extension of the `figure_key`. If it doesn't have ".svg" ending, it adds one before trying to pull it from the dict of figures. --------- Co-authored-by: Yael Ben-Haim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Figure names could be referred without ".svg" at the ending.
Details and comments
Some details that should be in this section include:
In #629 , an issue was raised where a figure that was saved with the name "abcd" couldn't be accessed. This issue is caused by that the 'add_figures()' method in
ExperimentDataclass added ".svg" automatically. As it explicitly written that SVG extension is added if the file name doesn't have one, we can conclude that all figure names have ".svg" extension. To not make a major change in the code I added to thefiguremethod inExperimentDataclass a check for the extension of thefigure_key. If it doesn't have ".svg" ending, it adds one before trying to pull it from the dict of figures.