Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of multiplication of cliffords #1275
Improve performance of multiplication of cliffords #1275
Changes from 2 commits
ff0ab80
fd5d029
811a1c2
8485824
b52c770
ef6ec4b
b57b652
b67caeb
212dfcd
ad795b6
b663dbd
dc9682d
f30cc1c
bd78614
3ee461a
caa947a
7bd41ec
57e3ab1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my memo. I'm surprised to know the custom dense matrix is faster than scipy.lil_matrix. If we used lil_matrix, the benchmark takes 18.76 sec, so about half of the improvement comes from the use of the custom dense matrix.