Constrain numpy in tests #1203
Merged
Constrain numpy in tests #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Short-term solution to #1204 |
|
We usually pin package versions directly in |
|
I don't have any strong opinions on this topic. I chose this approach to align with Terra. See here: Qiskit/qiskit#10306 Deviating from that approach is fine by me. |
coruscating
approved these changes
Jun 19, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
coruscating
added
the
backport stable potential
mergify bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
### Summary Numpy released a new version which has caused our tests to fail. See here for example in Terra: Qiskit/qiskit#10305 ### Details and comments This PR constrains the version of numpy in the tests. We will need to Qiskit to align with the new numpy. (cherry picked from commit a8142f1)
coruscating
pushed a commit
that referenced
this pull request
Jun 29, 2023
This is an automatic backport of pull request #1203 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Daniel J. Egger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Numpy released a new version which has caused our tests to fail. See here for example in Terra: Qiskit/qiskit#10305
Details and comments
This PR constrains the version of numpy in the tests. We will need to Qiskit to align with the new numpy.