Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PR template #1083

Merged
merged 3 commits into from
Mar 15, 2023
Merged

Conversation

coruscating
Copy link
Collaborator

Because we've set the merge queue to use the PR description as the commit message to main, it's not good to start the PR template with a commented block that PR makers don't have to remove. The new template makes the checklist visible at the end and indicates it should be deleted.

@coruscating coruscating requested a review from wshanks March 15, 2023 15:58
Copy link
Collaborator

@wshanks wshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. I wonder if the text should say somewhere that this description will be used as the commit message, so it should be updated as necessary and discussion of secondary aspects like test status should be kept to PR comments.

@coruscating coruscating enabled auto-merge March 15, 2023 17:39
@coruscating
Copy link
Collaborator Author

Good idea, added.

@coruscating coruscating added this pull request to the merge queue Mar 15, 2023
Merged via the queue into qiskit-community:main with commit 9e0bed4 Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants