faster transpile (qubit lookup) in rb code #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajavadia
force-pushed
the
faster-rb-qubit-lookup
branch
from
8cc6ac6 to
9e74b5f
Compare
ajavadia
force-pushed
the
faster-rb-qubit-lookup
branch
from
9e74b5f to
d511ed1
Compare
itoko
approved these changes
Jan 31, 2023
Comment on lines
+386
to
387
| qubit_indices = {bit: index for index, bit in enumerate(transpiled[0].qubits)} | ||
| for circ in transpiled: |
There was a problem hiding this comment.
All transpiled circuits has qubits with unique name "q" so no problem in these lines, but a bit slower
for circ in transpiled:
qubit_indices = {bit: index for index, bit in enumerate(circ.qubits)}
might be safer.
There was a problem hiding this comment.
but all RB circuits have the same qubits no? otherwise i think a test should have failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
a small improvement to make transpile faster in rb code as a follow up to #982
Details and comments