Fix circuit generation of 3Q+ InterleavedRB #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for RB circuit generation add doc
chriseclectic
added
the
Changelog: Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1013
Details and comments
In 3Q+ RB circuit generation, QuantumCircuit objects are internally used for Clifford elements to be composed to compute the last inversion. The recent large refactoring #982 embeds a bug in the handling of interleaved element. It wrongly stores a Clifford object as an interleaved Clifford element. This PR fixes the bug so that it stores a QuantumCircuit object consistently.