Reverse sign of fine frequency update (#699)

qiskit-community · Mar 1, 2022 · d2f0881 · d2f0881
1 parent ddddcb5
commit d2f0881
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/qiskit_experiments/library/calibration/fine_frequency_cal.py b/qiskit_experiments/library/calibration/fine_frequency_cal.py
@@ -140,7 +140,7 @@ def update_calibrations(self, experiment_data: ExperimentData):
         dt = experiment_data.metadata["dt"]
 
         d_theta = BaseUpdater.get_value(experiment_data, "d_theta", result_index)
-        new_freq = prev_freq - d_theta / (2 * np.pi * tau * dt)
+        new_freq = prev_freq + d_theta / (2 * np.pi * tau * dt)
 
         BaseUpdater.add_parameter_value(
             self._cals, experiment_data, new_freq, self._param_name, self._sched_name, group

diff --git a/test/calibration/experiments/test_fine_frequency.py b/test/calibration/experiments/test_fine_frequency.py
@@ -86,7 +86,7 @@ def test_calibration_version(self):
         freq_after = self.cals.get_parameter_value(self.cals.__drive_freq_parameter__, 0)
 
         # Test equality up to 10kHz on a 100 kHz shift
-        self.assertAlmostEqual(freq_after, armonk_freq - freq_shift, delta=1e4)
+        self.assertAlmostEqual(freq_after, armonk_freq + freq_shift, delta=1e4)
 
     def test_experiment_config(self):
         """Test converting to and from config works"""