Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old test class TestJaxBase #328

Merged

Conversation

DanPuzzuoli
Copy link
Collaborator

Summary

Details and comments

@DanPuzzuoli DanPuzzuoli requested a review from to24toro February 23, 2024 19:46
@to24toro
Copy link
Contributor

Thanks Dan.
This PR looks good for me.
In addition, Can we remove ArrayTest class e.g. ArrayNumpyTestBase?

@DanPuzzuoli
Copy link
Collaborator Author

Thanks Dan. This PR looks good for me. In addition, Can we remove ArrayTest class e.g. ArrayNumpyTestBase?

That's a good question. We're currently using it for Signal testing, and I was thinking we could keep it there since we will be deprecating Array and not getting rid of it right away. On the other hand, the usage of Array throughout the package generally is already broken, so it may not be worth maintaining tests for the signal class. What do you think?

@to24toro
Copy link
Contributor

Thanks. I consider that it is better to drop Array test cases at the same time that we will deprecate Array class.

@DanPuzzuoli DanPuzzuoli merged commit f99d651 into qiskit-community:main Feb 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants