Relax pin on Qiskit 1.0 #314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particular pulse test appears to be the only thing that changes in Qiskit 1.0. This commit adds a CI job to test against Qiskit 1.0.0rc1 (which can be removed, or made to target `qiskit<1` after 1.0.0 final is released), and relaxes the pin on `qiskit`.
|
|
|
A bit of a race condition with Dan - I made this on my side before #312 and #313 were public. I'm fine if this gets closed - the important thing from my side is just that there's a release of I added a test to the GitHub CI file that you might want to pinch, but it can't pass in its current form until there's a usable version of |
|
Thanks for this, but I will close it :) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This particular pulse test appears to be the only thing that changes in Qiskit 1.0. This commit adds a CI job to test against Qiskit 1.0.0rc1 (which can be removed, or made to target
qiskit<1after 1.0.0 final is released), and relaxes the pin onqiskit.Details and comments
The new test run will explode right now because of incompatible dependencies, but locally I used a modified version of
qiskit-experimentsthat stubbed out the bits that don't work with Qiskit 1.0, and this passed the test suite for me.This is presumably on hold til
qiskit-experimentsis ready.Admittedly I was running without Jax or diffrax - I assume that's not going to change anything, but I guess we'll see.