Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sparse modules to update dynamics by arraylias #286
Add sparse modules to update dynamics by arraylias #286
Changes from 11 commits
56f5e7a
1f0f136
a56088f
ab5ec7d
907a878
025454e
d9e537d
6687bb6
41d8fc7
d075ded
9fe669e
c962a34
64cbf56
8dccad1
44c1c4f
ced1dc4
9fdce08
903b42f
12ddc08
f6f109e
8b674fe
6567b8f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering now if this is actually necessary - this basically functions as
unp.asarray
except it has a default. Can we instead just register a default forasarray
? I think this should work - is there some intended distinction betweenasarray
andto_numeric_matrix_type
that I'm not remembering?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I'm just considering it, but I cannot decide it because it is used in model files I have not seen yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly, I also feel we can integrate it to asarray.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps for now just remove it and we'll see if it can be replaced effectively with
asarray
in the model files.